From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752685AbbIRNmJ (ORCPT ); Fri, 18 Sep 2015 09:42:09 -0400 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:46278 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbbIRNmH (ORCPT ); Fri, 18 Sep 2015 09:42:07 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <55FC14AC.9090202@mev.co.uk> Date: Fri, 18 Sep 2015 14:42:04 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Punit Vara CC: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, colinpatrickcronin@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: comedi: Fixed coding style issues in comedi.h References: <1442579441-5905-1-git-send-email-punitvara@gmail.com> In-Reply-To: <1442579441-5905-1-git-send-email-punitvara@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/09/15 13:30, Punit Vara wrote: > This patch is to the comedi.h file that fixes up following type > of 42 warning in the file: > > -Blocking comments use a trailing */ on a separate line > -Block comments use * on subsequent lines > > Signed-off-by: Punit Vara > > --- > drivers/staging/comedi/comedi.h | 183 +++++++++++++++++++++++----------------- > 1 file changed, 107 insertions(+), 76 deletions(-) > > diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h > index 66edda1..4bc4b6c 100644 > --- a/drivers/staging/comedi/comedi.h > +++ b/drivers/staging/comedi/comedi.h > @@ -1,20 +1,20 @@ > -/* > - include/comedi.h (installed as /usr/include/comedi.h) > - header file for comedi > - > - COMEDI - Linux Control and Measurement Device Interface > - Copyright (C) 1998-2001 David A. Schleef > - > - This program is free software; you can redistribute it and/or modify > - it under the terms of the GNU Lesser General Public License as published by > - the Free Software Foundation; either version 2 of the License, or > - (at your option) any later version. > - > - This program is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - GNU General Public License for more details. > -*/ > +/** That's the wrong sort of comment opening. It should be '/*'. The '/**' form is reserved for kernel-doc mark-up. > + * include/comedi.h (installed as /usr/include/comedi.h) > + * header file for comedi > + These blank lines in the block comment should be ' *'. (The same applies to the other comments you changed in this patch.) -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-