From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753820AbbIRNrW (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Sep 2015 09:47:22 -0400
Received: from eusmtp01.atmel.com ([212.144.249.243]:59463 "EHLO
	eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753758AbbIRNrU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Sep 2015 09:47:20 -0400
Subject: Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Josh Wu <josh.wu@atmel.com>
References: <27620a5315a0fd314e21eac4afbfe87f1350b099.1441897573.git.nicolas.ferre@atmel.com>
 <fca26d7ecb73e9691da4ee85e7e5bd8462638752.1441897573.git.nicolas.ferre@atmel.com>
 <20150910152415.GN3237@piout.net>
CC: <linux-arm-kernel@lists.infradead.org>,
        Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
        <linux-kernel@vger.kernel.org>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
X-Enigmail-Draft-Status: N1110
Organization: atmel
Message-ID: <55FC15B9.9070407@atmel.com>
Date: Fri, 18 Sep 2015 15:46:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150910152415.GN3237@piout.net>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.161.30.18]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Le 10/09/2015 17:24, Alexandre Belloni a écrit :
> Hi,
> 
> On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
>> From: Josh Wu <josh.wu@atmel.com>
>>
>> Correct the led labels in at91sam9n12ek.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>> ---
>>  arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
>> index efa75064d38a..186a1705f8d3 100644
>> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
>> @@ -204,13 +204,13 @@
>>  		};
>>  
>>  		d9 {
>> -			label = "d6";
>> +			label = "d9";
>>  			gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
>>  			linux,default-trigger = "nand-disk";
>>  		};
>>  
>>  		d10 {
>> -			label = "d7";
>> +			label = "d10";
>>  			gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
>>  			linux,default-trigger = "heartbeat";
>>  		};
> 
> The only concern being that this renaming will break userspace software
> assuming the LEDs are wrongly named. Is there anything that has been
> released by atmel that uses the wrong names (and my guess is yess and
> that is why there are named as such) and do you care about it?

My guess is that the label was wrongly named from the beginning and no
board revision had the "d6" nor "d7" names.
It makes sense to rename them for the evaluation kit...

Bye,
-- 
Nicolas Ferre