From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753743AbbIROYf (ORCPT ); Fri, 18 Sep 2015 10:24:35 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:6330 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109AbbIROYe (ORCPT ); Fri, 18 Sep 2015 10:24:34 -0400 Subject: Re: [PATCH] tty/serial: at91: move ATMEL_MAX_UART To: Alexandre Belloni , "Greg Kroah-Hartman" References: <1441877343-20248-1-git-send-email-alexandre.belloni@free-electrons.com> CC: Jiri Slaby , , , From: Nicolas Ferre Organization: atmel Message-ID: <55FC1E73.8020101@atmel.com> Date: Fri, 18 Sep 2015 16:23:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441877343-20248-1-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 10/09/2015 11:29, Alexandre Belloni a écrit : > Move ATMEL_MAX_UART from platform_data/atmel.h to atmel_serial.c as this is > the only file using it and it is common practise from tty/serial drivers to > define it directly in the driver file. > > Signed-off-by: Alexandre Belloni Okay: Acked-by: Nicolas Ferre > --- > drivers/tty/serial/atmel_serial.c | 6 ++++++ > include/linux/platform_data/atmel.h | 6 ------ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 5ca5cf3e9359..98c84038518e 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -112,6 +112,12 @@ struct atmel_uart_char { > #define ATMEL_SERIAL_RINGSIZE 1024 > > /* > + * at91: 6 USARTs and one DBGU port (SAM9260) > + * avr32: 4 > + */ > +#define ATMEL_MAX_UART 7 > + > +/* > * We wrap our port structure around the generic uart_port. > */ > struct atmel_uart_port { > diff --git a/include/linux/platform_data/atmel.h b/include/linux/platform_data/atmel.h > index 527a85c61924..c4bc90bfebe0 100644 > --- a/include/linux/platform_data/atmel.h > +++ b/include/linux/platform_data/atmel.h > @@ -19,12 +19,6 @@ > #include > #include > > -/* > - * at91: 6 USARTs and one DBGU port (SAM9260) > - * avr32: 4 > - */ > -#define ATMEL_MAX_UART 7 > - > /* USB Device */ > struct at91_udc_data { > int vbus_pin; /* high == host powering us */ > -- Nicolas Ferre