From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753640AbbIROlU (ORCPT ); Fri, 18 Sep 2015 10:41:20 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:51894 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbbIROlS (ORCPT ); Fri, 18 Sep 2015 10:41:18 -0400 Subject: Re: [PATCH] usb: gadget: at91_udc: move at91_udc_data in at91_udc.h To: Alexandre Belloni , Felipe Balbi , Greg Kroah-Hartman References: <1439217979-15642-1-git-send-email-alexandre.belloni@free-electrons.com> CC: , Boris Brezillon , , From: Nicolas Ferre Organization: atmel Message-ID: <55FC225F.2080207@atmel.com> Date: Fri, 18 Sep 2015 16:40:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1439217979-15642-1-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 10/08/2015 16:46, Alexandre Belloni a écrit : > struct at91_udc_data is now only used inside the driver, move it to its > include. > > Signed-off-by: Alexandre Belloni Acked-by: Nicolas Ferre Thanks. > --- > drivers/usb/gadget/udc/at91_udc.h | 8 ++++++++ > include/linux/platform_data/atmel.h | 9 --------- > 2 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/gadget/udc/at91_udc.h b/drivers/usb/gadget/udc/at91_udc.h > index 2679c8b217cc..0a433e6b346b 100644 > --- a/drivers/usb/gadget/udc/at91_udc.h > +++ b/drivers/usb/gadget/udc/at91_udc.h > @@ -112,6 +112,14 @@ struct at91_udc_caps { > void (*pullup)(struct at91_udc *udc, int is_on); > }; > > +struct at91_udc_data { > + int vbus_pin; /* high == host powering us */ > + u8 vbus_active_low; /* vbus polarity */ > + u8 vbus_polled; /* Use polling, not interrupt */ > + int pullup_pin; /* active == D+ pulled up */ > + u8 pullup_active_low; /* true == pullup_pin is active low */ > +}; > + > /* > * driver is non-SMP, and just blocks IRQs whenever it needs > * access protection for chip registers or driver state > diff --git a/include/linux/platform_data/atmel.h b/include/linux/platform_data/atmel.h > index 4b452c6a2f7b..2d67e466c51b 100644 > --- a/include/linux/platform_data/atmel.h > +++ b/include/linux/platform_data/atmel.h > @@ -25,15 +25,6 @@ > */ > #define ATMEL_MAX_UART 7 > > - /* USB Device */ > -struct at91_udc_data { > - int vbus_pin; /* high == host powering us */ > - u8 vbus_active_low; /* vbus polarity */ > - u8 vbus_polled; /* Use polling, not interrupt */ > - int pullup_pin; /* active == D+ pulled up */ > - u8 pullup_active_low; /* true == pullup_pin is active low */ > -}; > - > /* Compact Flash */ > struct at91_cf_data { > int irq_pin; /* I/O IRQ */ > -- Nicolas Ferre