From: Ian Abbott <abbotti@mev.co.uk>
To: Punit Vara <punitvara@gmail.com>
Cc: gregkh@gmail.com, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: Fixed coding style issue in comedilib.h
Date: Fri, 18 Sep 2015 15:42:27 +0100 [thread overview]
Message-ID: <55FC22D3.1080006@mev.co.uk> (raw)
In-Reply-To: <1442586885-3741-1-git-send-email-punitvara@gmail.com>
On 18/09/15 15:34, Punit Vara wrote:
> This patch is to the comedilib.h file that fixes up coding style issues
> and following warning:
>
> - Block comments use * on subsequent lines
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/staging/comedi/comedilib.h | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
> index 56baf85..45da22b 100644
> --- a/drivers/staging/comedi/comedilib.h
> +++ b/drivers/staging/comedi/comedilib.h
> @@ -1,20 +1,20 @@
> -/*
> - linux/include/comedilib.h
> - header file for kcomedilib
> +/**
Please use '/*' not '/**' here.
> + * linux/include/comedilib.h
> + * header file for kcomedilib
>
> - COMEDI - Linux Control and Measurement Device Interface
> - Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org>
> + * COMEDI - Linux Control and Measurement Device Interface
> + * Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License as published by
> - the Free Software Foundation; either version 2 of the License, or
> - (at your option) any later version.
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
>
> - This program is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - GNU General Public License for more details.
> -*/
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
Blank lines in the block comment should be ' *'.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2015-09-18 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 14:34 [PATCH] Staging: comedi: Fixed coding style issue in comedilib.h Punit Vara
2015-09-18 14:42 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC22D3.1080006@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=punitvara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox