From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753780AbbIRP3z (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Sep 2015 11:29:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60535 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751418AbbIRP3y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Sep 2015 11:29:54 -0400
Subject: Re: [linux-sunxi] [PATCH 1/4] ARM: dts: sun8i: Add PWM controller
 node for A23/A33
To: Chen-Yu Tsai <wens@csie.org>,
        Maxime Ripard <maxime.ripard@free-electrons.com>
References: <1442561739-6824-1-git-send-email-wens@csie.org>
 <1442561739-6824-2-git-send-email-wens@csie.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@googlegroups.com
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <55FC2DEC.7080104@redhat.com>
Date: Fri, 18 Sep 2015 11:29:48 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <1442561739-6824-2-git-send-email-wens@csie.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Good stuff, thanks for working on this.

On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote:
> A23/A33 have a PWM controller that is compatible to the one on the A20.
> Add a device node for it.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   arch/arm/boot/dts/sun8i-a23-a33.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> index 27a925ec17d2..e7054304018a 100644
> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> @@ -466,6 +466,14 @@
>   			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>   		};
>
> +		pwm: pwm@01c21400 {
> +			compatible = "allwinner,sun7i-a20-pwm";
> +			reg = <0x01c21400 0xc>;
> +			clocks = <&osc24M>;
> +			#pwm-cells = <3>;
> +			status = "disabled";
> +		};
> +
>   		lradc: lradc@01c22800 {
>   			compatible = "allwinner,sun4i-a10-lradc-keys";
>   			reg = <0x01c22800 0x100>;
>