From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754703AbbIRPcv (ORCPT ); Fri, 18 Sep 2015 11:32:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44082 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754657AbbIRPcl (ORCPT ); Fri, 18 Sep 2015 11:32:41 -0400 Subject: Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets To: Chen-Yu Tsai , Maxime Ripard References: <1442561739-6824-1-git-send-email-wens@csie.org> <1442561739-6824-4-git-send-email-wens@csie.org> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com From: Hans de Goede Message-ID: <55FC2E95.7040006@redhat.com> Date: Fri, 18 Sep 2015 11:32:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1442561739-6824-4-git-send-email-wens@csie.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote: > A23/A33 based Q8 format tablets use channel 0 of the PWM controller for > backlight dimming. > > Signed-off-by: Chen-Yu Tsai > --- > arch/arm/boot/dts/sun8i-q8-common.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi b/arch/arm/boot/dts/sun8i-q8-common.dtsi > index 6f8a8bb4e9bb..4c2d0b459d6f 100644 > --- a/arch/arm/boot/dts/sun8i-q8-common.dtsi > +++ b/arch/arm/boot/dts/sun8i-q8-common.dtsi > @@ -70,6 +70,12 @@ > }; > }; > > +&pwm { > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm0_pins>; > + status = "okay"; > +}; > + > &r_uart { > pinctrl-names = "default"; > pinctrl-0 = <&r_uart_pins_a>; > I've a feeling this should be in sunxi-q8-common.dtsi not sun8i-q8-common.dtsi, which requires adding a pwm node to sun5i.dtsi I'll look into this. Regards, Hans