From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754532AbbIRXvq (ORCPT ); Fri, 18 Sep 2015 19:51:46 -0400 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:19964 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752217AbbIRXvo (ORCPT ); Fri, 18 Sep 2015 19:51:44 -0400 X-IronPort-AV: E=Sophos;i="5.17,555,1437462000"; d="scan'208";a="75609702" Subject: Re: [PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding To: Kishon Vijay Abraham I References: <1442339797-6830-1-git-send-email-rjui@broadcom.com> <1442339797-6830-2-git-send-email-rjui@broadcom.com> <55FBAC8F.70409@ti.com> CC: Arnd Bergmann , , "JD (Jiandong) Zheng" , Arun Parameswaran , From: Ray Jui Message-ID: <55FCA38D.6070806@broadcom.com> Date: Fri, 18 Sep 2015 16:51:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55FBAC8F.70409@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/17/2015 11:17 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 15 September 2015 11:26 PM, Ray Jui wrote: >> Add DT binding for Broadcom Cygnus PCIe PHYs > > DT binding documentation. > > -Kishon > Yes will fix the commit message. >> >> Signed-off-by: Ray Jui >> Reviewed-by: Arun Parameswaran >> Reviewed-by: JD (Jiandong) Zheng >> Reviewed-by: Scott Branden > > >> --- >> .../bindings/phy/brcm,cygnus-pcie-phy.txt | 30 ++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> new file mode 100644 >> index 0000000..ba41143 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> @@ -0,0 +1,30 @@ >> +Broadcom Cygnus PCIe PHY >> + >> +Required properties: >> +- compatible: Must be "brcm,cygnus-pcie-phy" >> +- reg: base address and length of the PCIe PHY block >> +- #phy-cells: must be <1> >> +The first cell is the PHY ID: >> +0 - PCIe RC 0 >> +1 - PCIe RC 1 >> + >> +Example: >> + pcie_phy: phy@0301d0a0 { >> + compatible = "brcm,cygnus-pcie-phy"; >> + reg = <0x0301d0a0 0x14>; >> + #phy-cells = <1>; >> + }; >> + >> + pcie0: pcie@18012000 { >> + ... >> + ... >> + phys = <&pcie_phy 0>; >> + phy-names = "pcie-phy"; >> + }; >> + >> + pcie1: pcie@18013000 { >> + ... >> + ... >> + phys = <&pcie_phy 1>; >> + phy-names = "pcie-phy"; >> + }; >> Note this binding document will now change due to required changes in the phy driver following code review comments. Each phy will now be represented by a child node and #phy-cells will become 0 for each of the child. Thanks, Ray