From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754585AbbISAhj (ORCPT ); Fri, 18 Sep 2015 20:37:39 -0400 Received: from muin.pair.com ([209.68.1.55]:52015 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754170AbbISAhi (ORCPT ); Fri, 18 Sep 2015 20:37:38 -0400 Subject: Re: [RESEND PATCH 1/1] ASoC: fsl_ssi: Fix checking of dai format for AC97 mode To: Adam Thomson , Mark Brown , Nicolin Chen Cc: Xiubo Li , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, support.opensource@diasemi.com References: <409ab77432bd0553502b75ab98089bb7ecdb5018.1442394728.git.Adam.Thomson.Opensource@diasemi.com> From: undefined@vger.kernel.org Message-ID: <55FCAE4F.9040904@tabi.org> Date: Fri, 18 Sep 2015 19:37:35 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Firefox/38.0 SeaMonkey/2.35 MIME-Version: 1.0 In-Reply-To: <409ab77432bd0553502b75ab98089bb7ecdb5018.1442394728.git.Adam.Thomson.Opensource@diasemi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adam Thomson wrote: > Current code incorrectly treats dai format for AC97 as bit mask > whereas it's actually an integer value. This causes DAI formats > other than AC97 (e.g. DSP_B) to trigger AC97 related code, > which is incorrect and breaks functionality. This patch fixes > the code to correctly compare values to determine AC97 or not. > > Signed-off-by: Adam Thomson Acked-by: Timur Tabi