* [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver
@ 2015-09-15 16:42 Luis de Bethencourt
2015-09-19 1:53 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-09-15 16:42 UTC (permalink / raw)
To: linux-kernel; +Cc: Corey Minyard, openipmi-developer
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
drivers/char/ipmi/ipmi_si_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 967b73a..43e1fb24 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2784,6 +2784,7 @@ static struct of_device_id ipmi_match[] =
.data = (void *)(unsigned long) SI_BT },
{},
};
+MODULE_DEVICE_TABLE(of, ipmi_match);
static struct platform_driver ipmi_driver = {
.driver = {
--
2.4.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver
2015-09-15 16:42 [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-19 1:53 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2015-09-19 1:53 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel; +Cc: openipmi-developer
This is there now in the main kernel, but it's further down. Perhaps it
should be moved.
-corey
On 09/15/2015 11:42 AM, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 967b73a..43e1fb24 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2784,6 +2784,7 @@ static struct of_device_id ipmi_match[] =
> .data = (void *)(unsigned long) SI_BT },
> {},
> };
> +MODULE_DEVICE_TABLE(of, ipmi_match);
>
> static struct platform_driver ipmi_driver = {
> .driver = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-19 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-15 16:42 [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-19 1:53 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox