From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754307AbbISByE (ORCPT ); Fri, 18 Sep 2015 21:54:04 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:35024 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753353AbbISByB (ORCPT ); Fri, 18 Sep 2015 21:54:01 -0400 Message-ID: <55FCC037.5080306@acm.org> Date: Fri, 18 Sep 2015 20:53:59 -0500 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Luis de Bethencourt , linux-kernel@vger.kernel.org CC: openipmi-developer@lists.sourceforge.net Subject: Re: [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver References: <20150915164206.GA5693@goodgumbo.baconseed.org> In-Reply-To: <20150915164206.GA5693@goodgumbo.baconseed.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is there now in the main kernel, but it's further down. Perhaps it should be moved. -corey On 09/15/2015 11:42 AM, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- > drivers/char/ipmi/ipmi_si_intf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 967b73a..43e1fb24 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -2784,6 +2784,7 @@ static struct of_device_id ipmi_match[] = > .data = (void *)(unsigned long) SI_BT }, > {}, > }; > +MODULE_DEVICE_TABLE(of, ipmi_match); > > static struct platform_driver ipmi_driver = { > .driver = {