From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbbISVja (ORCPT ); Sat, 19 Sep 2015 17:39:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49944 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbbISVj2 (ORCPT ); Sat, 19 Sep 2015 17:39:28 -0400 Subject: Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets To: wens@csie.org References: <1442561739-6824-1-git-send-email-wens@csie.org> <1442561739-6824-4-git-send-email-wens@csie.org> <55FC2E95.7040006@redhat.com> Cc: Maxime Ripard , linux-arm-kernel , linux-kernel , linux-sunxi From: Hans de Goede Message-ID: <55FDD60B.7080204@redhat.com> Date: Sat, 19 Sep 2015 17:39:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 09/18/2015 12:25 PM, Chen-Yu Tsai wrote: > On Fri, Sep 18, 2015 at 11:32 PM, Hans de Goede wrote: >> Hi, >> >> On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote: >>> >>> A23/A33 based Q8 format tablets use channel 0 of the PWM controller for >>> backlight dimming. >>> >>> Signed-off-by: Chen-Yu Tsai >>> --- >>> arch/arm/boot/dts/sun8i-q8-common.dtsi | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi >>> b/arch/arm/boot/dts/sun8i-q8-common.dtsi >>> index 6f8a8bb4e9bb..4c2d0b459d6f 100644 >>> --- a/arch/arm/boot/dts/sun8i-q8-common.dtsi >>> +++ b/arch/arm/boot/dts/sun8i-q8-common.dtsi >>> @@ -70,6 +70,12 @@ >>> }; >>> }; >>> >>> +&pwm { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pwm0_pins>; >>> + status = "okay"; >>> +}; >>> + >>> &r_uart { >>> pinctrl-names = "default"; >>> pinctrl-0 = <&r_uart_pins_a>; >>> >> >> I've a feeling this should be in sunxi-q8-common.dtsi not >> sun8i-q8-common.dtsi, which requires adding a pwm >> node to sun5i.dtsi I'll look into this. > > It probably should. Which means the name of the pinctrl node should be the same on both, hence my request to rename that. Anyways Maxime has already merged that now, I'll workaround it and / or do a followup patch. > IIRC sun5i PWM has only one channel as opposed to > 2 on A10/A20. Nope sun5i has 2 channels, but the second channel is only routed to the outside on A10s, not on A13. Regards, Hans