From: Knuth Posern <knuth@posern.org>
To: linux-kernel@vger.kernel.org
Cc: Andreas Noever <andreas.noever@gmail.com>,
Greg KH <greg@kroah.com>,
linux-pci@vger.kernel.org
Subject: [PATCH] Thunderbolt 2 driver for recent Apple MacBooks
Date: Sun, 20 Sep 2015 18:11:25 +0200 [thread overview]
Message-ID: <55FEDAAD.6000804@posern.org> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 687 bytes --]
Hi,
This patch is submitted for upstream inclusion.
This is a first for me, so I hope the format of this mail is convenient.
Thanks to Greg and Andreas the attached patch (diff -up) fixes the bug:
https://bugzilla.kernel.org/show_bug.cgi?id=100191
The pci device ids listed in the tb driver are to restrictive, which
prevents the driver from being loaded. We have had a similar issue
with the new Mac mini.
Changing the subvendor and subdevice to PCI_ANY_ID in
drivers/thunderbolt/nhi.c
the thunderbolt driver loads and binds to the pci device
07:00.0 System peripheral: Intel Corporation Device 156c
which is the thunderbolt 2 controller.
Cheers,
Knuth.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: diff.patch --]
[-- Type: text/x-patch; name="diff.patch", Size: 454 bytes --]
--- linux/drivers/thunderbolt/nhi.c.orig 2015-09-20 17:36:14.014964300 +0200
+++ linux/drivers/thunderbolt/nhi.c 2015-09-13 09:58:18.000000000 +0200
@@ -643,7 +643,7 @@ static struct pci_device_id nhi_ids[] =
{
.class = PCI_CLASS_SYSTEM_OTHER << 8, .class_mask = ~0,
.vendor = PCI_VENDOR_ID_INTEL, .device = 0x156c,
- .subvendor = 0x2222, .subdevice = 0x1111,
+ .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID,
},
{ 0,}
};
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next reply other threads:[~2015-09-20 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 16:11 Knuth Posern [this message]
2015-09-20 17:24 ` [PATCH] Thunderbolt 2 driver for recent Apple MacBooks Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FEDAAD.6000804@posern.org \
--to=knuth@posern.org \
--cc=andreas.noever@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox