From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756787AbbIUNDQ (ORCPT ); Mon, 21 Sep 2015 09:03:16 -0400 Received: from mout.web.de ([212.227.15.4]:61452 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756693AbbIUNDO (ORCPT ); Mon, 21 Sep 2015 09:03:14 -0400 Subject: Re: [PATCH v3] coccinelle: tests: unsigned value cannot be lesser than zero To: Andrzej Hajda References: <1442831864-25759-1-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Gilles Muller , Joe Perches , Nicolas Palix , Michal Marek , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <55FFFFF4.4000007@users.sourceforge.net> Date: Mon, 21 Sep 2015 15:02:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442831864-25759-1-git-send-email-a.hajda@samsung.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:6AWZ7WDqZDh09oa5Ho0C51TCEsOp4LOGI1MqJZSVzU988IYcGI1 TuD/9NIlf7K6Sa4sfjlJpEXTAyCgousPC8BZJzhVdgESOKE2fckpUITWaLuCUNkAAdmNKAp l6joIwbeHsrL+N2B8DNba4NZClt69TenfzygYYr7CEPDgdomHEmc6iwXuxmrTGXf85xhQXp rBTNeURbh9y7ZENuEc4mA== X-UI-Out-Filterresults: notjunk:1;V01:K0:9oHdZhSspCA=:hs0O8QINx7rAK0/sHXjxgl XAYOJhELWa8Ux1YlokGPLe3+kl/rPYyLs1DQJZc7LfFh4HmTxEX1rv5eZKn5vpMd+uzqwaS4k 9mB4+IXSw5wfefg8pMmCQynD4PouksmYjxYOodHSDjZmcztMA4aEcivUdYnN5k+t2OJPClnyr BrDnHNwSrLuFNMaeD6ZeHctpydbjEJltosMY1q/eEopKL0o0DwxNaBUwya3oCuXH/2FR9YS6J 1LqspcBxwqe2UPpJavgeMRMQc9T3uYLdogRDqpePxCTlS0u0ZEKu5Q+qXx773mCHsFWRs7Nmu ZJpS2SwK4UY7g47TBFARlUW3B/aIvRhZ5vwM2wkWT06PdVwAv+owwgqDMWzDhxVGrXZdpiDuc UqV9l/xwEw0ndgZdB6AUcoG55N9mA7wIRN+pa8bZm5d4CW/T5xNKa4UKcduIpVDQQTYkZ1L3f yquRyeNK11IC/wWD5+4X8G3dPIrD6ICLQcqa6qeMR4xC5X2nPblAnrYedCm/aLgMGCn5AJD/E 8tHppq1B1rWIJD9QNBj44GJvmtC2/K+K2uKYIK/xpuOrpDuZ1q9l5C8SWrD45Y2jBoTyRTyYy dZLFW/nUv6ThwaEofQ+QrII7lMOZQKl7i0jjnpjQfjBC5vkfSTKVrNhekt8xdRra7xmsHEf57 y3eAhh9JtGT0xTqnSdxfDulmphzAeSgiFy2YIrKP+AOWd1DD7YHLvozYZOwgfIc+L2murDRYG rV7jh1mJMtiEkpwZGgxiTUXl9OOeH9ChYj+fig== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > v3: added bool type I would appreciate a bit more feedback for my concerns around your evolving approach. * Reuse of "long int"? * Splitting of the suggested SmPL rule so that each source code check will be connected with appropriate warning messages. Will any more fine-tuning be useful? Regards, Markus