Re: [PATCH v5 03/24] ARM: tegra: Add labels to tegra30.dtsi

Thierry Reding
2021-12-10T15:22:22Z

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

On Wed, Dec 08, 2021 at 08:35:48PM +0300, Dmitry Osipenko wrote:
> From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>
> Add phandle names for memory/I2C/SPI/USB/SDMMC controller nodes to allow
> for cleaner device descriptions.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> arch/arm/boot/dts/tegra30.dtsi | 36 +++++++++++++++++-----------------
> 1 file changed, 18 insertions(+), 18 deletions(-)

We typically only add those when they are really needed. These are
technically harmless because without a reference, DTC won't actually
create a phandle property, but dangling labels are the kind of thing
that some janitor may at some point want to remove with some scripts,
so I'm hesitant to apply this because it'll likely cause churn in the
future.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]