From: Damien Le Moal <dlemoal@kernel.org>
To: Matthias Schiffer <mschiffer@universe-factory.net>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] ata: libata: increase PMP SRST timeout to 10s
Date: Fri, 22 Sep 2023 13:05:46 -0700 [thread overview]
Message-ID: <55ab5197-51ba-87bf-e24d-44ebc45f13d7@kernel.org> (raw)
In-Reply-To: <ace8c25c-cc62-4719-bcd1-8020881ed178@universe-factory.net>
On 2023/09/22 12:41, Matthias Schiffer wrote:
>>> Even with the latest series applied, I still need my
>>> ATA_TMOUT_PMP_SRST_WAIT change to avoid the "softreset failed (1st FIS
>>> failed)" message (and get "softreset failed (device not ready)" instead).
>>
>> OK. Thank you for testing.
>> For increasing the timeout, please send a proper patch. I will queue it.
>>
>>
>
> Will do. Do you see any downsides to the increased timeout? Otherwise, I'd
> simply add a Fixes: tag for the last time the timeout was touched in
> e7d3ef13d52a126438f687a1a32da65ff926ed57.
No, I do not see any downside. Most drives do not need such long timeout for
replying to a reset, so it should not be an issue. Increasing to 10s should be
OK. But please be sure to mention in the commit message the adapter and drive
you have that need this, so that we keep a trace of it.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2023-09-22 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 16:18 [RFC] ata: libata: increase PMP SRST timeout to 10s Matthias Schiffer
2023-09-22 16:36 ` Damien Le Moal
2023-09-22 18:47 ` Matthias Schiffer
2023-09-22 18:59 ` Damien Le Moal
2023-09-22 19:41 ` Matthias Schiffer
2023-09-22 20:05 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ab5197-51ba-87bf-e24d-44ebc45f13d7@kernel.org \
--to=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschiffer@universe-factory.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox