public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Liao Chen <liaochen4@huawei.com>, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, naohiro.aota@wdc.com, jth@kernel.org
Subject: Re: [PATCH -next] zonefs: add support for FS_IOC_GETFSSYSFSPATH
Date: Mon, 19 Aug 2024 13:08:04 +0900	[thread overview]
Message-ID: <55ca393e-e2e9-45ef-8eb0-050d79c92987@kernel.org> (raw)
In-Reply-To: <20240809013627.3546649-1-liaochen4@huawei.com>

On 8/9/24 10:36, Liao Chen wrote:
> FS_IOC_GETFSSYSFSPATH ioctl expects sysfs sub-path of a filesystem, the
> format can be "$FSTYP/$SYSFS_IDENTIFIER" under /sys/fs, it can helps to
> standardizes exporting sysfs datas across filesystems.
> 
> This patch wires up FS_IOC_GETFSSYSFSPATH for zonefs, it will output
> "zonefs/<dev>".
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>  fs/zonefs/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index faf1eb87895d..e180daa39578 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -1262,6 +1262,7 @@ static int zonefs_fill_super(struct super_block *sb, struct fs_context *fc)
>  	sb->s_maxbytes = 0;
>  	sb->s_op = &zonefs_sops;
>  	sb->s_time_gran	= 1;
> +	super_set_sysfs_name_id(sb);

Can you resend the patch with this call moved to the beginning of
zonefs_sysfs_register() in fs/zonefs/sysfs.c ?
Thanks.

>  
>  	/*
>  	 * The block size is set to the device zone write granularity to ensure

-- 
Damien Le Moal
Western Digital Research


  reply	other threads:[~2024-08-19  4:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09  1:36 [PATCH -next] zonefs: add support for FS_IOC_GETFSSYSFSPATH Liao Chen
2024-08-19  4:08 ` Damien Le Moal [this message]
2024-08-19 12:22 ` liaochen (A)
2024-08-19 23:10   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ca393e-e2e9-45ef-8eb0-050d79c92987@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=jth@kernel.org \
    --cc=liaochen4@huawei.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox