Re: [PATCH 03/13] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c

David Howells
2015-09-17T09:57:35Z

Palmer Dabbelt <palmer@dabbelt.com> wrote:

> +#ifdef CONFIG_COMPAT
> +/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */
> +#define COMPAT_ATM_ADDPARTY _IOW('a', ATMIOC_SPECIAL+4, struct compat_atm_iobuf)
> +#endif

I wonder if it would hurt to ditch the conditionals entirely. It only eats
cpp namespace, not C namespace so it won't affect the output if it is not used
because the code that uses it is compiled out.

David