From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbcEIUN0 (ORCPT ); Mon, 9 May 2016 16:13:26 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:63985 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752139AbcEIUNV (ORCPT ); Mon, 9 May 2016 16:13:21 -0400 From: Arnd Bergmann To: Pablo Neira Ayuso Cc: Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , Florian Westphal , Daniel Borkmann , Sasha Levin , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: remove uninitialized shadow variable Date: Mon, 09 May 2016 22:12:31 +0200 Message-ID: <5600782.TOr8CDRnac@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160509200117.GA6957@salvia> References: <1462823254-3137116-1-git-send-email-arnd@arndb.de> <20160509200117.GA6957@salvia> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:OGb+u/8Faq+E0OTPBX8+nLt1wTa4vU+blYwbUnDPXCR2SJdxGME 2kr47ljnvUi+GhvsEhO/ljqTvGRB260zlnqM94vpYVSSa2dQ9BYDTASrm2reV1t7+dJV9rE 1tiWHhfuwqzCQtldIxQGoD3B2WT8cJu4PMwow96alhvYWbA1Akx4OpgO+fb9D+ltU8Yme2N QJMVlmgniywpQJOqomzPg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Pn0CI4LYJ9U=:GX7/QJjgSnfgdCycXPmfWI tCKoMXMKfkwHH6FAH7lc0wp8bP/loK14dVaVuzoMszIs6wNy8QjkHGYhc5q3mLWRXSXSeMzRO Adf4Ou37owrjnhuXqjyvvncoio8q5LGrUOq5jkRMzVoBOO97056Haq9lVSyzyNb0gOBpLaHRd gSmAERGuZcVAjvoXSD/a0qE2bNzchDTxGpzoZIA8pldeOzeC0VAzCN9xhR4npsToNCFZZuDfo GIGYdGU7sKxuFqmlFdnCYEnV5QhgtP4ye0r6oxWyCjF772+ijkP7a7OEMGds0RcQhKOSml2uK N9SNv5pEfOyZCS2jA18x507aVK1JLQpT5wS31Moyf7ybPDP+3r6vQNlcoWoV6IpL8orZbvGdk 08H5H3C4w6cbFQ73XonXeJX+aA6kx5puADREvplwIb39N/xug+maX4imQ2J3ZGpq1EQG1A7lt wejRKSI0AMma8nT4FhzwB3nU1nVjV3eIFiSNFEcGS7rnm5msN5ktJdAw61YGAfBOnOdzVHrjn amgfblpoCwCHL3TRUFVvxtnLUIcxFOGUuiBzyHkhkF4Sci4aDH35DNyANArrOKBUSUrOGAhHT Yl7mt5kyhALrHdIgrvxza+1j035TxxxFdPzD1v/Hc9yWQ0X1cgTl/TZWHNxR8ThmxYuVZBTL4 QWV6gGkoTo9mjBd88HgG9XDsvi9V6S64O7YqvmI4HjC/Mygwpg2nNz7vtF0EY8Rq4iWNxWBhH RYF++KAf0WiFq2/p Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 09 May 2016 22:01:17 Pablo Neira Ayuso wrote: > On Mon, May 09, 2016 at 09:47:23PM +0200, Arnd Bergmann wrote: > > A recent commit introduced an unconditional use of an uninitialized > > variable, as reported in this gcc warning: > > > > net/netfilter/nf_conntrack_core.c: In function '__nf_conntrack_confirm': > > net/netfilter/nf_conntrack_core.c:632:33: error: 'ctinfo' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > bytes = atomic64_read(&counter[CTINFO2DIR(ctinfo)].bytes); > > ^ > > net/netfilter/nf_conntrack_core.c:628:26: note: 'ctinfo' was declared here > > enum ip_conntrack_info ctinfo; > > > > The problem is that a local variable shadows the function parameter. > > This removes the local variable, which looks like what Pablo originally > > intended. > > Acked-by: Pablo Neira Ayuso > > Sorry for this, I wonder why gcc didn't catch up this here. > > @David, you can integrate this into your net-next tree. > > Thanks for fixing up this Arnd. By default, an allmodconfig build will hide these warnings because of excessive false positives from CONFIG_CC_OPTIMIZE_FOR_SIZE. I've tried twice to get a patch merged that disables CONFIG_CC_OPTIMIZE_FOR_SIZE in allmodconfig so we get better warnings, but that patch unfortunately got ignored. Arnd