From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757600AbbIVBhQ (ORCPT ); Mon, 21 Sep 2015 21:37:16 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:52689 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757437AbbIVBhN (ORCPT ); Mon, 21 Sep 2015 21:37:13 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <9af5f814dbdd6433862ba4064537d277> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/3] mmc: debugfs: fix memory leak for mmc_ext_csd_open To: trick wong References: <1442884713-11193-1-git-send-email-shawn.lin@rock-chips.com> Cc: shawn.lin@rock-chips.com, Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: Shawn Lin Message-ID: <5600B0BD.704@rock-chips.com> Date: Tue, 22 Sep 2015 09:37:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/9/22 9:29, trick wong wrote: > In the correct path,this buf will used later.why freed? > right. sorry for this noise, withdraw this patch[1/3]. > 2015-09-22 9:18 GMT+08:00 Shawn Lin >: > > buf allocated isn't been freed before return, so we fix it. > > Fixes: 736bb6bb01a ("mmc: Add Extended CSD register to debugfs") > Signed-off-by: Shawn Lin > > --- > > drivers/mmc/core/debugfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c > index e914210..b2ab936 100644 > --- a/drivers/mmc/core/debugfs.c > +++ b/drivers/mmc/core/debugfs.c > @@ -304,6 +304,7 @@ static int mmc_ext_csd_open(struct inode *inode, > struct file *filp) > > filp->private_data = buf; > kfree(ext_csd); > + kfree(buf); > return 0; > > out_free: > -- > 2.3.7 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Best Regards Shawn Lin