From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932922AbbIVHhY (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Sep 2015 03:37:24 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:64748 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932340AbbIVHhX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Sep 2015 03:37:23 -0400
X-AuditID: cbfec7f5-f794b6d000001495-04-560105304864
Message-id: <5601052C.50809@samsung.com>
Date: Tue, 22 Sep 2015 09:37:16 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: linux-kernel@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Richard Purdie <rpurdie@rpsys.net>, linux-leds@vger.kernel.org
Subject: Re: [PATCH 31/38] leds: tca6507: remove invalid check
References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com>
 <1442842450-29769-32-git-send-email-a.hajda@samsung.com>
In-reply-to: <1442842450-29769-32-git-send-email-a.hajda@samsung.com>
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xy7oGrIxhBrN7RC1urTvHarFxxnpW
	i8u75rBZbH2zjtFi7ZG77Ba7dz1ldWDz2DP/B6tH35ZVjB6fN8kFMEdx2aSk5mSWpRbp2yVw
	Zdxf3cpesI2jYkFDA1MD42u2LkZODgkBE4nTHy8zQthiEhfurQeKc3EICSxllFi6ew8jhPOM
	UeLJremsIFW8AhoSDbO6mUBsFgFVicmze5lBbDYBQ4mfL16DxUUFIiT+nN4HVS8o8WPyPRYQ
	W0RAXWL2yTvMIEOZBU4ySpx8uQasQVjATuLXretgDUICdRJ3P0E0cwq4SrycMR/sPGYBa4mV
	k7ZB2fISm9e8ZZ7AKDALyY5ZSMpmISlbwMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMk
	lL/uYFx6zOoQowAHoxIPr0cfQ5gQa2JZcWXuIUYJDmYlEd7n/4FCvCmJlVWpRfnxRaU5qcWH
	GKU5WJTEeWfueh8iJJCeWJKanZpakFoEk2Xi4JRqYEx87J4kNDvwmFbsnVCJl9rLY0vk8jKe
	n2jcFuQfyCRwSirKxbPgwet5jXWhG8wfm8x411Z0lXmlzMKVJ1vd0pwu30l84Zp2ZLH0992r
	7Ocdm/9hl9mR+G17JJSD2rYWtlzcye8+q3WTkGD1iqcLXRck++ZxF31aLrvEh0tWbFpR/4Ot
	7vnOBUosxRmJhlrMRcWJAMkHZPRhAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrzej,

On 09/21/2015 03:34 PM, Andrzej Hajda wrote:
> unsigned value cannot be lesser than zero.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>   drivers/leds/leds-tca6507.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
> index edbecc4..93564f6 100644
> --- a/drivers/leds/leds-tca6507.c
> +++ b/drivers/leds/leds-tca6507.c
> @@ -713,7 +713,7 @@ tca6507_led_dt_init(struct i2c_client *client)
>   		if (of_property_match_string(child, "compatible", "gpio") >= 0)
>   			led.flags |= TCA6507_MAKE_GPIO;
>   		ret = of_property_read_u32(child, "reg", &reg);
> -		if (ret != 0 || reg < 0 || reg >= NUM_LEDS)
> +		if (ret != 0 || reg >= NUM_LEDS)
>   			continue;
>
>   		tca_leds[reg] = led;
>

Merged, thanks.

-- 
Best Regards,
Jacek Anaszewski