From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933327AbbIVNCF (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Sep 2015 09:02:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50946 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757711AbbIVNCC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Sep 2015 09:02:02 -0400
Subject: Re: [linux-sunxi] Re: [PATCH 5/5] ARM: sun5i: Add C.H.I.P DTS
To: Chen-Yu Tsai <wens@csie.org>,
        Maxime Ripard <maxime.ripard@free-electrons.com>
References: <1442566130-3497-1-git-send-email-maxime.ripard@free-electrons.com>
 <1442566130-3497-6-git-send-email-maxime.ripard@free-electrons.com>
 <CAGb2v64E-gQu1U_qi2fTWiCmfgMdMR4X6yLUerV21d3E1uQ1cw@mail.gmail.com>
 <20150922124708.GZ4684@lukather>
 <CAGb2v662+mhFgv1DXz5muA+xGE99R1DVKOxtVPvJmc+tRFPXzQ@mail.gmail.com>
Cc: Mike Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <56015146.2070509@redhat.com>
Date: Tue, 22 Sep 2015 15:01:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <CAGb2v662+mhFgv1DXz5muA+xGE99R1DVKOxtVPvJmc+tRFPXzQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 22-09-15 14:57, Chen-Yu Tsai wrote:
> On Tue, Sep 22, 2015 at 8:47 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:

<snip>

>>>> +&usb_otg {
>>>> +       dr_mode = "otg";
>>>> +       status = "okay";
>>>> +};
>>>> +
>>>> +&usbphy {
>>>> +       pinctrl-names = "default";
>>>> +       pinctrl-0 = <&chip_id_det_pin>;
>>>> +       status = "okay";
>>>> +
>>>> +       usb0_id_det-gpio = <&pio 6 2 GPIO_ACTIVE_HIGH>; /* PG2 */
>>>
>>> Better leave a comment here saying VBUS detection requires AXP209
>>> usb-power-supply support.
>>
>> Does it? It can be powered by a battery, with or without VBUS, and
>> that wouldn't be tied to the fact that the power-supply is USB or
>> something else.
>
> The AXP209 VBUS / USB power-supply also doubles for VBUS detection,
> which on most boards is done using a separate GPIO pin. Hans posted
> support for the AXP20X power-supply driver, and support in the usb
> phy driver using it for VBUS detection.

Ack.

> In short, this is not about "power supply" but VBUS detection. IIRC,
> if no VBUS detection method is provided, the phy driver just waits a
> period of time after an ID pin change and then considers VBUS invalid.

Right, but that is a hack for boards with no / broken vbus detection
(or vbus control), we really want to use vbus-det where available,
so I agree that a TODO comment here would be good.

Regards,

Hans