From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933779AbbIVRA5 (ORCPT ); Tue, 22 Sep 2015 13:00:57 -0400 Received: from mail-qg0-f49.google.com ([209.85.192.49]:33643 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752097AbbIVRAy (ORCPT ); Tue, 22 Sep 2015 13:00:54 -0400 Subject: Re: [PATCH] powercap / RAPL : remove dependency on iosf_mbi To: Jacob Pan References: <1442475101-1872-1-git-send-email-pengyu.ma@windriver.com> <1542119.JQ7HNYzFZu@vostro.rjw.lan> <20150918084356.4bf149a6@yairi> <55FF7DFE.8050906@windriver.com> <20150921143629.4f597e1c@icelake> <56015AA0.1020104@gmail.com> <20150922085730.14bafdec@icelake> Cc: Pengyu Ma , "Rafael J. Wysocki" , rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org From: Austin S Hemmelgarn Message-ID: <56018944.7080104@gmail.com> Date: Tue, 22 Sep 2015 13:00:52 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150922085730.14bafdec@icelake> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-512; boundary="------------ms030606000309090008010708" X-Antivirus: avast! (VPS 150922-0, 2015-09-22), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms030606000309090008010708 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 2015-09-22 11:57, Jacob Pan wrote: > On Tue, 22 Sep 2015 09:41:52 -0400 > Austin S Hemmelgarn wrote: > >> On 2015-09-21 17:36, Jacob Pan wrote: >>> On Mon, 21 Sep 2015 11:48:14 +0800 >>> Pengyu Ma wrote: >>> >>>> >>>> >>>> On 09/18/2015 11:43 PM, Jacob Pan wrote: >>>>> On Fri, 18 Sep 2015 02:09:55 +0200 >>>>> "Rafael J. Wysocki" wrote: >>>>> >>>>>> On Thursday, September 17, 2015 03:31:41 PM Pengyu Ma wrote: >>>>>>> iosf_mbi is supported on Quark, Braswell, Baytrail and some Atom >>>>>>> SoC, but RAPL is not limited to these SoC, it supports almost >>>>>>> Intel CPUs. Remove this dependece to make RAPL support more >>>>>>> Intel CPUs. >>>>>>> >>>>>>> Please select IOSF_MBI on Atom SoCs. >>>>>>> >>>>> Unlike Quark, I don't think we want to or do differentiate Atom >>>>> from other x86 at compile time. IOSF driver can be compiled as a >>>>> module also, therefore RAPL driver needs this explicit dependency >>>>> at compile time. >>>> As commit had exported iosf_mbi to let user use it. >>>> >>>> commit aa8e4f22ab7773352ba3895597189b8097f2c307 >>>> Author: David E. Box >>>> Date: Wed Aug 27 14:40:39 2014 -0700 >>>> >>>> x86/iosf: Add Kconfig prompt for IOSF_MBI selection >>>> >>>> >>>> While selecting IOSF_MBI is preferred, it does mean carrying extra >>>> code on non-SoC architectures. >>>> >>>> We can NOT force user to build in iosf_mbi if they want use RAPL on >>>> haswell/broadwell/skylake. >>>> And RAPL can be compiled and worked well on >>>> haswell/broadwell/skylake without IOSF_MBI. >>>> RAPL is really NOT depended on IOSF_MBI. >>>> >>> True for haswell/broadwell/skylake platforms. But if we want binary >>> compatibility for Atom and Core, I can' see how simply removing the >>> dependency would work, unless we have runtime detection of IOSF. >> So make RAPL select IOSF instead of depending on it, add something to >> the RAPL help text saying that IOSF is needed for it to work on >> SoC's, and make IOSF=3Dy in the defconfig. >> >> This way, people who just turn on RAPL support should get IOSF, >> whereas people like me who actually build custom kernels for each >> system we own aren't forced to include yet more code that is 100% >> useless for us. >> > If you build a custom kernel for Core with RAPL, your kernel would stil= l > "select" IOSF which is not needed. right? I think so, select behaves inconsistently in my experience with stuff=20 that can be built as a module though. It might also be necessary to=20 ensure that if IOSF is built as a module, then RAPL has to be a module=20 too (not sure if this is the case though). >> It's also worth noting that most of the people who care about binary >> compatibility for a wide variety of chips in one kernel (read as >> 'distro maintainers') will be turning IOSF on anyway, because it's >> needed for other things on chips that have it to work right as well. >> > true. no issue for that case. >>>> Pengyu >>>>>>> Signed-off-by: Pengyu Ma >>>>>> Jacob? >>>>>> >>>>>>> --- >>>>>>> drivers/powercap/Kconfig | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/drivers/powercap/Kconfig b/drivers/powercap/Kconfig >>>>>>> index 85727ef..a7c81b5 100644 >>>>>>> --- a/drivers/powercap/Kconfig >>>>>>> +++ b/drivers/powercap/Kconfig >>>>>>> @@ -17,7 +17,7 @@ if POWERCAP >>>>>>> # Client driver configurations go here. >>>>>>> config INTEL_RAPL >>>>>>> tristate "Intel RAPL Support" >>>>>>> - depends on X86 && IOSF_MBI >>>>>>> + depends on X86 >>>>>>> default n >>>>>>> ---help--- >>>>>>> This enables support for the Intel Running Average >>>>>>> Power Limit (RAPL) >>>>>>> >>>>> [Jacob Pan] >>>> >>> >>> [Jacob Pan] >>> -- >>> To unsubscribe from this list: send the line "unsubscribe >>> linux-kernel" in the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> Please read the FAQ at http://www.tux.org/lkml/ >>> >> >> > > [Jacob Pan] > --------------ms030606000309090008010708 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgMFADCABgkqhkiG9w0BBwEAAKCC Brgwgga0MIIEnKADAgECAgMRLfgwDQYJKoZIhvcNAQENBQAweTEQMA4GA1UEChMHUm9vdCBD QTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNp Z25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcwHhcN MTUwOTIxMTEzNTEzWhcNMTYwMzE5MTEzNTEzWjBjMRgwFgYDVQQDEw9DQWNlcnQgV29UIFVz ZXIxIzAhBgkqhkiG9w0BCQEWFGFoZmVycm9pbjdAZ21haWwuY29tMSIwIAYJKoZIhvcNAQkB FhNhaGVtbWVsZ0BvaGlvZ3QuY29tMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA nQ/81tq0QBQi5w316VsVNfjg6kVVIMx760TuwA1MUaNQgQ3NyUl+UyFtjhpkNwwChjgAqfGd LIMTHAdObcwGfzO5uI2o1a8MHVQna8FRsU3QGouysIOGQlX8jFYXMKPEdnlt0GoQcd+BtESr pivbGWUEkPs1CwM6WOrs+09bAJP3qzKIr0VxervFrzrC5Dg9Rf18r9WXHElBuWHg4GYHNJ2V Ab8iKc10h44FnqxZK8RDN8ts/xX93i9bIBmHnFfyNRfiOUtNVeynJbf6kVtdHP+CRBkXCNRZ qyQT7gbTGD24P92PS2UTmDfplSBcWcTn65o3xWfesbf02jF6PL3BCrVnDRI4RgYxG3zFBJuG qvMoEODLhHKSXPAyQhwZINigZNdw5G1NqjXqUw+lIqdQvoPijK9J3eijiakh9u2bjWOMaleI SMRR6XsdM2O5qun1dqOrCgRkM0XSNtBQ2JjY7CycIx+qifJWsRaYWZz0aQU4ZrtAI7gVhO9h pyNaAGjvm7PdjEBiXq57e4QcgpwzvNlv8pG1c/hnt0msfDWNJtl3b6elhQ2Pz4w/QnWifZ8E BrFEmjeeJa2dqjE3giPVWrsH+lOvQQONsYJOuVb8b0zao4vrWeGmW2q2e3pdv0Axzm/60cJQ haZUv8+JdX9ZzqxOm5w5eUQSclt84u+D+hsCAwEAAaOCAVkwggFVMAwGA1UdEwEB/wQCMAAw VgYJYIZIAYb4QgENBEkWR1RvIGdldCB5b3VyIG93biBjZXJ0aWZpY2F0ZSBmb3IgRlJFRSBo ZWFkIG92ZXIgdG8gaHR0cDovL3d3dy5DQWNlcnQub3JnMA4GA1UdDwEB/wQEAwIDqDBABgNV HSUEOTA3BggrBgEFBQcDBAYIKwYBBQUHAwIGCisGAQQBgjcKAwQGCisGAQQBgjcKAwMGCWCG SAGG+EIEATAyBggrBgEFBQcBAQQmMCQwIgYIKwYBBQUHMAGGFmh0dHA6Ly9vY3NwLmNhY2Vy dC5vcmcwMQYDVR0fBCowKDAmoCSgIoYgaHR0cDovL2NybC5jYWNlcnQub3JnL3Jldm9rZS5j cmwwNAYDVR0RBC0wK4EUYWhmZXJyb2luN0BnbWFpbC5jb22BE2FoZW1tZWxnQG9oaW9ndC5j b20wDQYJKoZIhvcNAQENBQADggIBADMnxtSLiIunh/TQcjnRdf63yf2D8jMtYUm4yDoCF++J jCXbPQBGrpCEHztlNSGIkF3PH7ohKZvlqF4XePWxpY9dkr/pNyCF1PRkwxUURqvuHXbu8Lwn 8D3U2HeOEU3KmrfEo65DcbanJCMTTW7+mU9lZICPP7ZA9/zB+L0Gm1UNFZ6AU50N/86vjQfY WgkCd6dZD4rQ5y8L+d/lRbJW7ZGEQw1bSFVTRpkxxDTOwXH4/GpQfnfqTAtQuJ1CsKT12e+H NSD/RUWGTr289dA3P4nunBlz7qfvKamxPymHeBEUcuICKkL9/OZrnuYnGROFwcdvfjGE5iLB kjp/ttrY4aaVW5EsLASNgiRmA6mbgEAMlw3RwVx0sVelbiIAJg9Twzk4Ct6U9uBKiJ8S0sS2 8RCSyTmCRhJs0vvva5W9QUFGmp5kyFQEoSfBRJlbZfGX2ehI2Hi3U2/PMUm2ONuQG1E+a0AP u7I0NJc/Xil7rqR0gdbfkbWp0a+8dAvaM6J00aIcNo+HkcQkUgtfrw+C2Oyl3q8IjivGXZqT 5UdGUb2KujLjqjG91Dun3/RJ/qgQlotH7WkVBs7YJVTCxfkdN36rToPcnMYOI30FWa0Q06gn F6gUv9/mo6riv3A5bem/BdbgaJoPnWQD9D8wSyci9G4LKC+HQAMdLmGoeZfpJzKHMYIE0TCC BM0CAQEwgYAweTEQMA4GA1UEChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNl cnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcN AQkBFhJzdXBwb3J0QGNhY2VydC5vcmcCAxEt+DANBglghkgBZQMEAgMFAKCCAiEwGAYJKoZI hvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTUwOTIyMTcwMDUyWjBPBgkq hkiG9w0BCQQxQgRAYtj57ZIEkKwvKkdAuxXYKqPlYLtHzgwspe3AZcPdZCR6rAwItmM4xGV3 5yNSyYB7fh5uB8eq9XhAbhTnC+yjpTBsBgkqhkiG9w0BCQ8xXzBdMAsGCWCGSAFlAwQBKjAL BglghkgBZQMEAQIwCgYIKoZIhvcNAwcwDgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3DQMCAgFA MAcGBSsOAwIHMA0GCCqGSIb3DQMCAgEoMIGRBgkrBgEEAYI3EAQxgYMwgYAweTEQMA4GA1UE ChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlD QSBDZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2Vy dC5vcmcCAxEt+DCBkwYLKoZIhvcNAQkQAgsxgYOggYAweTEQMA4GA1UEChMHUm9vdCBDQTEe MBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNpZ25p bmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcCAxEt+DAN BgkqhkiG9w0BAQEFAASCAgBD1x2sDrtGvk3DpfYiShxJgFt47oQIWIPLEbGUSYOenc4UyV6f oZZtj7TLnn1a2VeGqNZNu2EIwfLvMM8KJExaVVhfsgJ16Bi0rcKorsztUFD3sihXk3uPvOXK +z/xrS32RY2o3d5oTP2ZhDJiCsz1PGXRXCMaQhKrWc54BJInUg5Wn39YyJDR0AzgxA5eSuNm PVz1y/kYc7ruQL2bKcO6Zw0IPYjT/dBmKTWIqdo5dxvYKPCWWu/Sv1Sh0vYbvIvUpojqXCrI G5FaX/HIZGAJ0exXD7OQALo11liSdCoOAiE+Bp919xwv1KAvgSeEdH3yPHhpX4CAw/Z2+q6O EZ/jIlLzXR744LI1QLVQLf6fXNkIn/cJss5CE/uMcC5nWvUCUMFXqmyaCvHKZJHh7D2cdPGs 5h2rLVBTvYYXWisKLPdsUDVekKJH5G8fVPV3UtIIBrIxC7TzFrCNN8rpYYMdsbzsf3C9GTVh XWoevxrumw2jZRoUbOzGQdq+wt0BuVCDPXp5pQNv953K+8QpMXyXLc0ZCcmeCqIfu3ddg5B/ POzC8IZDbAh7RjF0oG781fAbD/yjt/20r4MFIKNKVcCcP81upKBenw4LwMIEdGHuN1Bawxy+ k0dUCnO0MY4x9m9iBu3Ou8p8IBDYVwAH0WJd5ACuCPgu63u/Xy4b2Idj8AAAAAAAAA== --------------ms030606000309090008010708--