From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934391AbbIVT6z (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Sep 2015 15:58:55 -0400
Received: from www.sr71.net ([198.145.64.142]:41576 "EHLO blackbird.sr71.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752960AbbIVT6y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Sep 2015 15:58:54 -0400
Subject: Re: [PATCH 05/26] x86, pkey: add PKRU xsave fields and data
 structure(s)
To: Thomas Gleixner <tglx@linutronix.de>
References: <20150916174903.E112E464@viggo.jf.intel.com>
 <20150916174905.0ECA529B@viggo.jf.intel.com>
 <alpine.DEB.2.11.1509222152300.5606@nanos>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
From: Dave Hansen <dave@sr71.net>
Message-ID: <5601B2F9.3030906@sr71.net>
Date: Tue, 22 Sep 2015 12:58:49 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.11.1509222152300.5606@nanos>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/22/2015 12:53 PM, Thomas Gleixner wrote:
> On Wed, 16 Sep 2015, Dave Hansen wrote:
>> --- a/arch/x86/kernel/fpu/xstate.c~pkeys-03-xsave	2015-09-16 10:48:13.340060126 -0700
>> +++ b/arch/x86/kernel/fpu/xstate.c	2015-09-16 10:48:13.344060307 -0700
>> @@ -23,6 +23,8 @@ static const char *xfeature_names[] =
>>  	"AVX-512 opmask"		,
>>  	"AVX-512 Hi256"			,
>>  	"AVX-512 ZMM_Hi256"		,
>> +	"unknown xstate feature (8)"	,
> 
> It's not unknown. It's PT, right?

Yes, it's the Processor Trace state.

I'll give it a real name and also a comment about it being unused.