From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934670AbbIVU36 (ORCPT ); Tue, 22 Sep 2015 16:29:58 -0400 Received: from www.sr71.net ([198.145.64.142]:41898 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbbIVU36 (ORCPT ); Tue, 22 Sep 2015 16:29:58 -0400 Subject: Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key faults To: Thomas Gleixner References: <20150916174903.E112E464@viggo.jf.intel.com> <20150916174906.51062FBC@viggo.jf.intel.com> <5601B82F.6070601@sr71.net> Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Dave Hansen Message-ID: <5601BA44.8080604@sr71.net> Date: Tue, 22 Sep 2015 13:29:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/2015 01:27 PM, Thomas Gleixner wrote: >> > >> > So I defined all the kernel-internal types as u16 since I *know* the >> > size of the hardware. >> > >> > The user-exposed ones should probably be a bit more generic. I did just >> > realize that this is an int and my proposed syscall is a long. That I >> > definitely need to make consistent. >> > >> > Does anybody care whether it's an int or a long? > long is frowned upon due to 32/64bit. Even if that key stuff is only > available on 64bit for now .... Well, it can be used by 32-bit apps on 64-bit kernels. Ahh, that's why we don't see any longs in the siginfo. So does that mean 'int' is still our best bet in siginfo?