[PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[Punit Vara]

This patch is to rtl8712_gp_bitdef.h file that fixes up following
warning reported by checkpatch :

-Block comments use a trailing */ on a separate line

Signed-off-by: Punit Vara <punitvara@gmail.com>
---
 drivers/staging/rtl8712/rtl8712_gp_bitdef.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl8712_gp_bitdef.h b/drivers/staging/rtl8712/rtl8712_gp_bitdef.h
index 138ea45..266b6172d 100644
--- a/drivers/staging/rtl8712/rtl8712_gp_bitdef.h
+++ b/drivers/staging/rtl8712/rtl8712_gp_bitdef.h
@@ -62,9 +62,11 @@
 
 /*----------------------------------------------------------------------------*/
 
-#define		GPIOMUX_EN	BIT(3)	/* When this bit is set to "1",
+#define		GPIOMUX_EN	BIT(3)	/*
+					 * When this bit is set to "1",
 					 * GPIO PINs will switch to MAC
-					 * GPIO Function*/
+					 * GPIO Function
+					 */
 #define		GPIOSEL_GPIO	0	/* UART or JTAG or pure GPIO*/
 #define		GPIOSEL_PHYDBG	1	/* PHYDBG*/
 #define		GPIOSEL_BT	2	/* BT_coex*/
-- 
2.5.2

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[Sudip Mukherjee]

On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote:
> This patch is to rtl8712_gp_bitdef.h file that fixes up following
> warning reported by checkpatch :
> 
> -Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
I am getting confused. One of your previous patch showed PATCH 5/6, this
one shows 13/13, but i am not seeing the other patches of these two
series. Is it the problem with my mail filters or you are not sending?

regards
sudip

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[Jaime Arrocha]

On 09/23/2015 12:31 AM, Sudip Mukherjee wrote:
> On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote:
>> This patch is to rtl8712_gp_bitdef.h file that fixes up following
>> warning reported by checkpatch :
>>
>> -Block comments use a trailing */ on a separate line
>>
>> Signed-off-by: Punit Vara <punitvara@gmail.com>
>> ---
> I am getting confused. One of your previous patch showed PATCH 5/6, this
> one shows 13/13, but i am not seeing the other patches of these two
> series. Is it the problem with my mail filters or you are not sending?
>
> regards
> sudip
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
I think the sender is not clearing the patch folder before sending a new 
one. Thus her/his diff program thinks these patches belong to a series.

-Jaime

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[punit vara]

On Wed, Sep 23, 2015 at 12:55 PM, Jaime Arrocha <jarr@innercoder.com> wrote:
>
> On 09/23/2015 12:31 AM, Sudip Mukherjee wrote:
>>
>> On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote:
>>>
>>> This patch is to rtl8712_gp_bitdef.h file that fixes up following
>>> warning reported by checkpatch :
>>>
>>> -Block comments use a trailing */ on a separate line
>>>
>>> Signed-off-by: Punit Vara <punitvara@gmail.com>
>>> ---
>>
>> I am getting confused. One of your previous patch showed PATCH 5/6, this
>> one shows 13/13, but i am not seeing the other patches of these two
>> series. Is it the problem with my mail filters or you are not sending?
>>
>> regards
>> sudip
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
> I think the sender is not clearing the patch folder before sending a new
> one. Thus her/his diff program thinks these patches belong to a series.
>
> -Jaime
>

Sorry for inconvenience. I have forgot to change the subject of two
patches in between. So I have resent the same patches with right
subject so please do not consider those patches whose subject
represent part of series.


It would be better if someone suggest me how to create independent
patch when already I have few patches in directory .  Or is it
necessary to clear directory every time whenever we work on new
problems ?

TIA

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[Sudip Mukherjee]

On Wed, Sep 23, 2015 at 07:32:52PM +0530, punit vara wrote:
> On Wed, Sep 23, 2015 at 12:55 PM, Jaime Arrocha <jarr@innercoder.com> wrote:
> >
> > On 09/23/2015 12:31 AM, Sudip Mukherjee wrote:
> >>
> >> On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote:
<snip>
> 
> 
> It would be better if someone suggest me how to create independent
> patch when already I have few patches in directory .  Or is it
> necessary to clear directory every time whenever we work on new
> problems ?
I think I have already told you how to use git format-patch to generate
single patch when you mailed me offlist.

regards
sudip

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[punit vara]

On Wed, Sep 23, 2015 at 9:04 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Wed, Sep 23, 2015 at 07:32:52PM +0530, punit vara wrote:
>> On Wed, Sep 23, 2015 at 12:55 PM, Jaime Arrocha <jarr@innercoder.com> wrote:
>> >
>> > On 09/23/2015 12:31 AM, Sudip Mukherjee wrote:
>> >>
>> >> On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote:
> <snip>
>>
>>
>> It would be better if someone suggest me how to create independent
>> patch when already I have few patches in directory .  Or is it
>> necessary to clear directory every time whenever we work on new
>> problems ?
> I think I have already told you how to use git format-patch to generate
> single patch when you mailed me offlist.
>
> regards
> sudip



Yes sir I remembered your advice . But  it was creating all the time
patch starting from 0001-... that is why It was difficult to remember
different patches for me so I used to change last number accordingly.
Thank you again for remind me .I would follow that from now onward

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[Sudip Mukherjee]

On Wed, Sep 23, 2015 at 09:51:23PM +0530, punit vara wrote:
> On Wed, Sep 23, 2015 at 9:04 PM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Wed, Sep 23, 2015 at 07:32:52PM +0530, punit vara wrote:
> >> On Wed, Sep 23, 2015 at 12:55 PM, Jaime Arrocha <jarr@innercoder.com> wrote:
> >> >
> >> > On 09/23/2015 12:31 AM, Sudip Mukherjee wrote:
> >> >>
> >> >> On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote:
> > <snip>
> >>
> >>
> >> It would be better if someone suggest me how to create independent
> >> patch when already I have few patches in directory .  Or is it
> >> necessary to clear directory every time whenever we work on new
> >> problems ?
> > I think I have already told you how to use git format-patch to generate
> > single patch when you mailed me offlist.
> >
> > regards
> > sudip
> 
> 
> 
> Yes sir I remembered your advice . But  it was creating all the time
> patch starting from 0001-... that is why It was difficult to remember
> different patches for me so I used to change last number accordingly.
> Thank you again for remind me .I would follow that from now onward
Don't use -n with git format-patch, the numbers will not be added in the
subject.

regards
sudip

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[punit vara]

Thank you very much sir I will definitely follow that. I have seen so
many people fixing patches over here. Now I know process of submitting
patches.I am able to fix several patches created by checkpatch.pl .
But can you suggest me any driver to fix API or another small TODO
task. I have seen so many TODO but confuse where to start . Can you
give me some initial idea or though or any driver to fix bugs  ? :-)

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[punit vara]

On Wed, Sep 23, 2015 at 10:25 PM, punit vara <punitvara@gmail.com> wrote:
> Thank you very much sir I will definitely follow that. I have seen so
> many people fixing patches over here. Now I know process of submitting
> patches.I am able to fix several patches created by checkpatch.pl .
> But can you suggest me any driver to fix API or another small TODO
> task. I have seen so many TODO but confuse where to start . Can you
> give me some initial idea or though or any driver to fix bugs  ? :-)


Dear Sudip sir,

I have used git format-patch master..my_local_branch But It also
produce numbers in subject of patch.
Now I have used git format-patch master..my_local_branch -N ..It does
not generate any number in patch even if you have previous patches

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[Sudip Mukherjee]

On Wed, Sep 23, 2015 at 11:22:09PM +0530, punit vara wrote:
> On Wed, Sep 23, 2015 at 10:25 PM, punit vara <punitvara@gmail.com> wrote:
> > Thank you very much sir I will definitely follow that. I have seen so
> > many people fixing patches over here. Now I know process of submitting
> > patches.I am able to fix several patches created by checkpatch.pl .
> > But can you suggest me any driver to fix API or another small TODO
> > task. I have seen so many TODO but confuse where to start . Can you
> > give me some initial idea or though or any driver to fix bugs  ? :-)
> 
> 
> Dear Sudip sir,
> 
> I have used git format-patch master..my_local_branch But It also
> produce numbers in subject of patch.
> Now I have used git format-patch master..my_local_branch -N ..It does
> not generate any number in patch even if you have previous patches
Usually I will not diff between the master and my local branch. I will
sync my local branch with the master in the morning and commit my
changes there. Now while generating the patch if I want to generate my
last patch then I just use git format-patch -1. If you want last 2
patches then use git format-patch -2. If you want to have them in series
with the numbering in the subject use git format-patch -2 -n.
And please dont use "sir".

regards
sudip

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

[punit vara]

On Thu, Sep 24, 2015 at 9:55 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Wed, Sep 23, 2015 at 11:22:09PM +0530, punit vara wrote:
>> On Wed, Sep 23, 2015 at 10:25 PM, punit vara <punitvara@gmail.com> wrote:
>> > Thank you very much sir I will definitely follow that. I have seen so
>> > many people fixing patches over here. Now I know process of submitting
>> > patches.I am able to fix several patches created by checkpatch.pl .
>> > But can you suggest me any driver to fix API or another small TODO
>> > task. I have seen so many TODO but confuse where to start . Can you
>> > give me some initial idea or though or any driver to fix bugs  ? :-)
>>
>>
>> Dear Sudip sir,
>>
>> I have used git format-patch master..my_local_branch But It also
>> produce numbers in subject of patch.
>> Now I have used git format-patch master..my_local_branch -N ..It does
>> not generate any number in patch even if you have previous patches
> Usually I will not diff between the master and my local branch. I will
> sync my local branch with the master in the morning and commit my
> changes there. Now while generating the patch if I want to generate my
> last patch then I just use git format-patch -1. If you want last 2
> patches then use git format-patch -2. If you want to have them in series
> with the numbering in the subject use git format-patch -2 -n.
> And please dont use "sir".
>
> regards
> sudip


Thank you for sharing.