Re: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode

John Youn
2015-09-24T04:21:21Z

On 9/10/2015 6:14 PM, Scott Branden wrote:
> This patch contains a fix for a real world interop problem found
> when using the Synopsis DWC2 USB controller with isochronous audio as
> detailed in the commit message.
>
> Changes from v2:
> - created s2c_hsotg_chage_ep_iso_parity function to call function in 3 places in code
> - used hsotg->num_of_eps instead of MAX_EPS_CHANNELS
>
> Changes from v1:
> - Address code review comments as per previous responses:
> - renamed parity_set to has_correct_parity and reorder some logic
>
>
> Roman Bacik (1):
> usb: dwc2: gadget: parity fix in isochronous mode
>
> drivers/usb/dwc2/core.h | 1 +
> drivers/usb/dwc2/gadget.c | 58 ++++++++++++++++++++++++++++++++++++++++++-----
> drivers/usb/dwc2/hw.h | 1 +
> 3 files changed, 54 insertions(+), 6 deletions(-)
>

This seems to break slave mode on my platform. It seems to be
dropping a lot of packets. I tried bInterval=4,5,6, ISO OUT.
I'll need to take a closer look to determine why. Probably later
this week.

Are you able to run in slave mode on your platform? If so can you
try it out?

Regards,
John