From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008AbbIWIxz (ORCPT ); Wed, 23 Sep 2015 04:53:55 -0400 Received: from foss.arm.com ([217.140.101.70]:33697 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753700AbbIWIxv (ORCPT ); Wed, 23 Sep 2015 04:53:51 -0400 Subject: Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag To: Lee Jones , Dmitry Torokhov References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-8-git-send-email-sudeep.holla@arm.com> <20150921232132.GE11284@x1> <20150922210632.GB3442@x1> Cc: Sudeep Holla , "linux-pm@vger.kernel.org" , lkml , Thomas Gleixner , "Rafael J. Wysocki" , Samuel Ortiz From: Sudeep Holla Message-ID: <5602689C.30000@arm.com> Date: Wed, 23 Sep 2015 09:53:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150922210632.GB3442@x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/15 22:08, Lee Jones wrote: > On Mon, 21 Sep 2015, Dmitry Torokhov wrote: > >> On Mon, Sep 21, 2015 at 4:21 PM, Lee Jones wrote: >>> The $SUBJECT is not correct. >>> >>>> The driver handles wakeup irq correctly using irq_set_irq_wake. There's >>>> no need to use IRQF_NO_SUSPEND while registering the interrupt. >>>> >>>> This patch removes the use of IRQF_NO_SUSPEND flag. >>>> >>>> Cc: Samuel Ortiz >>>> Cc: Lee Jones >>>> Signed-off-by: Sudeep Holla >>>> --- >>>> drivers/mfd/qcom_rpm.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> ... code is fine though: >>> >>> Acked-by: Lee Jones >>> >>> Please re-submit with the subject line fixed. >> >> What's wrong with the subject? > > This patch has nothing to do with Input and the first word of the > explanatory sentence should start with an uppercase character. > Ah my stupid mistake, I didn't realize it. Sorry for the noise, will fix it and send. Regards, Sudeep