From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754944AbbIWNNB (ORCPT ); Wed, 23 Sep 2015 09:13:01 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:36474 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754701AbbIWNM7 (ORCPT ); Wed, 23 Sep 2015 09:12:59 -0400 Subject: Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done To: "Felipe F. Tonello" , linux-usb@vger.kernel.org References: <1443009704-30320-1-git-send-email-eu@felipetonello.com> Cc: linux-kernel@vger.kernel.org, Peter Chen , Greg Kroah-Hartman , Felipe Balbi , Andrzej Pietrasiewicz From: Sergei Shtylyov Message-ID: <5602A558.4070605@cogentembedded.com> Date: Wed, 23 Sep 2015 16:12:56 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443009704-30320-1-git-send-email-eu@felipetonello.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 9/23/2015 3:01 PM, Felipe F. Tonello wrote: > req->actual == req->length means that there is no data left to enqueue, > so free the request. > > Signed-off-by: Felipe F. Tonello > --- > > Changes in v2: > * Re enqueue not fully completed requests, instead of read ALSA buffers. > > drivers/usb/gadget/function/f_midi.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index edb84ca..62356cf 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -256,10 +256,12 @@ f_midi_complete(struct usb_ep *ep, struct usb_request *req) > /* We received stuff. req is queued again, below */ > f_midi_handle_out_data(ep, req); > } else if (ep == midi->in_ep) { > - /* Our transmit completed. See if there's more to go. > - * f_midi_transmit eats req, don't queue it again. */ > - f_midi_transmit(midi, req); > - return; > + /* Our transmit completed. If there is no more to go, > + don't queue it again. */ The preferred multi-line comment style is this: /* * bla * bla */ MBR, Sergei