From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755494AbbIWQAr (ORCPT ); Wed, 23 Sep 2015 12:00:47 -0400 Received: from mail-bn1on0063.outbound.protection.outlook.com ([157.56.110.63]:64432 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753284AbbIWQAp (ORCPT ); Wed, 23 Sep 2015 12:00:45 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <5602CCA4.8070606@caviumnetworks.com> Date: Wed, 23 Sep 2015 09:00:36 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Arnd Bergmann CC: , David Daney , , Will Deacon , Marc Zyngier , Catalin Marinas , Bjorn Helgaas , , David Daney Subject: Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges. References: <1442966996-13419-1-git-send-email-ddaney.cavm@gmail.com> <1675889.xYIhzenZEC@wuerfel> In-Reply-To: <1675889.xYIhzenZEC@wuerfel> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: DM2PR07CA0048.namprd07.prod.outlook.com (10.141.52.176) To BN3PR0701MB1719.namprd07.prod.outlook.com (25.163.39.18) X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1719;2:/aHA27HuXs0x+zRPLYL5RmT/VLeaxlTauYY8I5JY/QyG/8uuHRV1M0XBbl4kCv0pzQZXyXTsj4Sj+OxGGhZNojncv6sXh2mLEGCxpyhmsIFoGw73LEruzCtKQAkQ1H+a5+LSgFqOwVScdn2fJUlLyOyO3DteomO/nD8Xpgd+l20=;3:cE9eZ0vX4S8pv30b0p+T0yfL3sdPi55ujbDBeSfYiNKfy7hmfCxWGAd1mp1RfhUm7rsTjR07ReFfWbILpGkbIIVaO8EwnXIP0eCJGqoTvWcl1eoRXpJxQJqWrsY5NnM7wtW2bPIFk4b3eQ4zhybQPw==;25:siweTGh2XVBCadMOedNsFh7ExoazbCSrpbLT7dJzQAijBaaIhvm3TdC0V4u1GqJFWwl98ghO6Ykiu4hnY3dB3AB4ZWCyl7mgHAjRHSqFdfN/5rNVKO6GCVmEg4LcT3a/igS7Jj+mfs2OBUhpUaJu8hSu7bs7OeEMzdWkBn9mLiO/ceMWuL4rHzoHrO4xvbvZzpY32agi2mRuDimDOSJCuhXWxEA0hrMbbxMDhDtyD5jgwCNISCHur2DHt2vRTgAy X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1719; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1719;20:izsCOexup3NGSQLwn+06u5puqSjPCYKRmcASwKHTLsqtNRcX720WkkBlxMNRYOxY6I1i/1VXNB/+b+D+ViexxpNTJ/lT3j7eXvk1wrWmHe4Nv1KpkzMblKj7LoIahPypgEigkFVqOJBCCaUnptxdBa7fTfLBNhxAwj50NW0F0X5ie99g/765zUPxbTXTUwNgXE0143kndvfS2+UqP/u3aE8bxR1OH0NatebjwJriluVV8ZU6DvF96Ubg6k8cDY7+5SvFPCpuPj9LAv+dhsxDRaHgpp7AK07L6KdENaeNqGQg7lWep41xwH2YuzeH4oYRwqvdaYQlyz/Z1uldC3/5a0IiEuz4kOaGymNUNXn7vJk4zzhymLiKxWF/0zxXLX15aVZmcW+IAmTewkZCwIA3UxgX16WQUp9VKcW4k2dAW3I5ERw9ojSq5u9Lmql25bWgJUVsSUGTDZQd5E5GWutq2B9Hj65+81AT6cS7CO9KBV5lu1c40GjNEd2xpnfKfBJI6qW9TBg0KvoTD7AChxpTSW3wyO67IlDbIWTDh7liOeZl+iml+4eLrE0rCYRkQ12qow41qI+9pGAltJqv15KOBku6u9sc0vaJJGgDUGWnGH8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001);SRVR:BN3PR0701MB1719;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1719; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1719;4:j2So2tJsSWmpC7FgqP0UkYGEAJhehConpjIO5MsdwbdLJTrTdHmX/dVjjyPwxvECFmlaePzt5wVDC5c+Hv3x6zE+6da1wqIKjMKRVHwbgc+sSiqlkLXZxreLZOrNKYvRPrxEc0taMGpjjcNj4zG4X6zrvORxyJ1cDVxwQVvHitCLLLM4sX5JznvctJUAceXVNfOkmJboq8HPGpKHwVJUmtldYS7xywiJdcYtqHMTZ2n3RIvkjVsee4/be1i97wHZHxVUJLzTS/rZ6BxRNBr5UjJhk3V2BZiRaKhPNV4/dsElqKwn2EcfiyJpb06x2reGU1fYe7hsJ8FmUQstflkPMxMiZGuIMtgYGt3RNIDDYws= X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(199003)(24454002)(377454003)(189002)(479174004)(77156002)(101416001)(110136002)(50986999)(87266999)(59896002)(5001960100002)(42186005)(4001540100001)(54356999)(97736004)(81156007)(5001830100001)(40100003)(53416004)(87976001)(5001860100001)(77096005)(33656002)(80316001)(105586002)(19580405001)(5004730100002)(36756003)(19580395003)(69596002)(62966003)(76176999)(122386002)(23756003)(64126003)(5007970100001)(65806001)(50466002)(64706001)(2950100001)(47776003)(46102003)(83506001)(65956001)(4001350100001)(66066001)(68736005)(92566002)(189998001)(65816999)(106356001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1719;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN3PR0701MB1719;23:rqHtM4GD1yMWwyCZm/hVIJBccFgIsYYzP/Ekd?= =?iso-8859-1?Q?uZYMY83R8Kc4cL7FsVtYGpHH6AM1gVQ128ZscNT0zoX8Fz0+wBcHX0CNWh?= =?iso-8859-1?Q?1YcNyBK4L/MHvMykMSJmq9YO7gbcnNNumocJjdS1GdSuOAgws5oOFJFKZz?= =?iso-8859-1?Q?mxnzAmXNFmNjMB68DQBXy3eMcKx+DRswtAAT/mb8b4V32h5xzs6UOC1+h7?= =?iso-8859-1?Q?ukAlk1WWzhVF6MTj6jkGDi/3YFYg1LIOR4mY3+HefepUcKKmEKcVYSkZ1K?= =?iso-8859-1?Q?vLQLaD8Gz3b3+EGh9QLdBNni2foshaAKqreu1pZ4Yaww62ZEkZ8b/QxAJM?= =?iso-8859-1?Q?d86u0QxzQSkt2RoSMYNCqfNR7HJC6Ykz+HuBKnYqzLdt8GLsl1oixQNdcR?= =?iso-8859-1?Q?f/9ef+cismpkz3ItdrRUvam2fSgI6QktWII1jBFmfiG4wpKTPjTRsvmXhM?= =?iso-8859-1?Q?j8/WlgFJ5Nzz9m8HbD4b9+Kd4tIXr5y6FqUqcSFmNFovtQTsKAUoXwwBn/?= =?iso-8859-1?Q?iJlsRzPG2GvvWmTLK4saDYFPsKDG7wXwIGLTjmTM/38xp6+lCuvOkXFUn9?= =?iso-8859-1?Q?gfCoa/JW1jtjBUH0kpFMpV0tCy5HqfnP9QlX/5WT6ZmjbPhmmPyQiDSDa6?= =?iso-8859-1?Q?YlgR9bSBHcIYfkGo5kSrZjqa6AS4HiEvjlXWbgvKwVxK1F6vTsDwbfiQEo?= =?iso-8859-1?Q?DJfYPBjJf6cAZtT2Y+eYGxTymxjLID4y9nnQevV2cQ0gLNMmkjrwI/920j?= =?iso-8859-1?Q?EWF3YuT+Jg5ujgUi9xMZsXbiaZMZmeDzDdzDH5QdLDZAEWW4YcRIjzSuyk?= =?iso-8859-1?Q?iESZrlUM31VMIX7tIkh9ueNbCQ0WtdHrQEZVbfr1mXFZYjwA1Tqt+Ps2PY?= =?iso-8859-1?Q?z+1G7xusGH4VuJg8R6mi/TA/JOtzlf9qJ8qB98TAW0BYXiFm3lPg2Q99gi?= =?iso-8859-1?Q?y93H0nMd04TqFPKXy46OLjPk6RbGriMRUFNNlHWkySURVeyzRqge+z+hwF?= =?iso-8859-1?Q?hj4vq5m0ctY6J4/vUUvcmAFT9YxEl49Ujk1xPOMlxgbiSTTifeaqrl6lct?= =?iso-8859-1?Q?1RFn0E7Rwck/VWkCE3gWJHo6KkoKXfeGG5My3DsMMvY+tsCDTFJhUNg+bC?= =?iso-8859-1?Q?MpbCI32fz9ofDRd95zHc8TtHXzajoAaB/xCsLn1dGGw5cVmvcoM3rHUqSQ?= =?iso-8859-1?Q?cLfSZoSd90Ko/eSrMS6IxpO8oIG/CZYpgt2Qzan5hdkwaI1vrUJ2x0rLGg?= =?iso-8859-1?Q?vtIkVEQleR2MhjNHslEqEoguMci7ollHUM8ZROlcaB7eemeJ2NvaF7MDtJ?= =?iso-8859-1?Q?KcBtK1aMEm5cOjLdg+y61AV04yd0DwYQg+rgTI9r0HQK2prBSk+4ndfyoc?= =?iso-8859-1?Q?JZnzXdSt2n4/YR1a99fdEUSmnxizzEznQVht4tjjrAYdhUYv+gorJtF92O?= =?iso-8859-1?Q?7lGZv7EFv9NSKkG8w+Qta8YIiyGZoZUy+oYKP?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1719;5:AeR00EXJxGETVUMmhOPvpUlMHEmCZusAZxgR0Irvm7Z1vyq90khX2sXhEHdYovLpcgYQbjBAFFevGSCIO/SRPSuOL4qZEBM4xLx6zZVBOeQbXHBDfgOFRB2CeUxlMRZwIbc/MWk5qm9ZQo8cuyfSSg==;24:trbB6aRw1trhMyGNAFKhFj/HtH1XWPOgcslZ7NgK6VHM8KwB3RcOb5v97j0pvheB7LnY5qjvBg7lecs8x27CBwxoqV8mz9nQ7tR4uY1dOms=;20:xI2wphlUqyKL/OMMBAw/cB3Ie4FvHYlTdREOJGNqfT6pyAzwTwK4t4dMgZu69/LUtjX82ip8I9wATPZxyWx4rw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2015 16:00:40.5945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1719 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/2015 12:51 AM, Arnd Bergmann wrote: > On Tuesday 22 September 2015 17:09:56 David Daney wrote: >> From: David Daney >> >> The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges. >> Since it is arm64, create a new quirks.c file there to contain arm64 >> related quirks. Add the ThunderX bridge quirk, gated by a new config >> variable, so that it can be disabled for kernels that aren't expected >> to be used on ThunderX. >> >> Signed-off-by: David Daney >> --- >> arch/arm64/Kconfig | 11 +++++++++++ >> arch/arm64/kernel/Makefile | 2 +- >> arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 48 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm64/kernel/quirks.c >> > > Looks reasonable to me. Just one question: Is the same bridge used > on MIPS machines? No. The MIPS64 based OCTEON family of SoCs does not contain PCI-buses/config-space/bridges for on-chip hardware blocks. The on-chip blocks in OCTEON are all platform devices. So, ... > If so, maybe it should be moved to drivers/pci/quirks.c > instead for better reuse. The quirk is specific to some arm64 based SoCs, thus my idea to have arch specific quirks. David Daney