From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755865AbbIWQok (ORCPT ); Wed, 23 Sep 2015 12:44:40 -0400 Received: from mga14.intel.com ([192.55.52.115]:31629 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755692AbbIWQoi (ORCPT ); Wed, 23 Sep 2015 12:44:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,577,1437462000"; d="scan'208";a="811564261" Subject: Re: [PATCH 2/6] irqdomain: add a new send_ipi() to irq_domain_ops To: Qais Yousef , linux-kernel@vger.kernel.org, tglx@linutronix.de References: <1443019758-20620-1-git-send-email-qais.yousef@imgtec.com> <1443019758-20620-3-git-send-email-qais.yousef@imgtec.com> Cc: marc.zyngier@arm.com, jason@lakedaemon.net, linux-mips@linux-mips.org From: Jiang Liu Organization: Intel Message-ID: <5602D6F3.7030709@linux.intel.com> Date: Thu, 24 Sep 2015 00:44:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1443019758-20620-3-git-send-email-qais.yousef@imgtec.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/9/23 22:49, Qais Yousef wrote: > For generic ipi core to use. It takes hwirq as its sole argument. > Hopefully this is generic enough? Should we pass something more abstract? > > Signed-off-by: Qais Yousef > --- > include/linux/irqdomain.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h > index 9b3dc6c2a3cc..cef9e6158be0 100644 > --- a/include/linux/irqdomain.h > +++ b/include/linux/irqdomain.h > @@ -92,6 +92,7 @@ struct irq_domain_ops { > void (*activate)(struct irq_domain *d, struct irq_data *irq_data); > void (*deactivate)(struct irq_domain *d, struct irq_data *irq_data); > #endif > + void (*send_ipi)(irq_hw_number_t hwirq); Hi Qais, Instead of extending the irq_domain_ops, how about extending irq_chip instead? If we treat IPI as a sort of irq controller, and irq_chip is used to encapsulate all irq controller related operations, and irq_domain_ops is mainly used to allocated resources instead of operating corresponding hardware. Thanks! Gerry > }; > > extern struct irq_domain_ops irq_generic_chip_ops; >