From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756129AbbIWRIt (ORCPT ); Wed, 23 Sep 2015 13:08:49 -0400 Received: from mail-by2on0073.outbound.protection.outlook.com ([207.46.100.73]:10579 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755650AbbIWRIr (ORCPT ); Wed, 23 Sep 2015 13:08:47 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <5602DC97.1040505@caviumnetworks.com> Date: Wed, 23 Sep 2015 10:08:39 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Marc Zyngier CC: David Daney , , Will Deacon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , , , Grant Likely , Thomas Gleixner , Jason Cooper , David Daney Subject: Re: [PATCH v2 3/3] irqchip/gicv3-its: Handle OF device tree "msi-map" properties. References: <1442966406-13198-1-git-send-email-ddaney.cavm@gmail.com> <1442966406-13198-4-git-send-email-ddaney.cavm@gmail.com> <20150923180100.03844936@arm.com> In-Reply-To: <20150923180100.03844936@arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BY2PR07CA043.namprd07.prod.outlook.com (10.141.251.18) To CY1PR0701MB1727.namprd07.prod.outlook.com (25.163.21.141) X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1727;2:+WPTYZHIiTMrAc7cS6RvcIQHBIfllMRC6MvVW6TZdJ6PAWieGVWktpfx1w9rDH4vGAnk+eSdmj2qPcgGCWr/ulWHmUwbLfQ66hgrUhSQ8gEs32ulp8AHeNmPMfvyAFj3r1vnv2FgHybhBz7FyYv4J4PJiPpnrGyJdANB1qt4cC8=;3:cRxpNJ9Ij/4K1K3v5btDYq61N7rAf96kml/5cCbDXBq8wrIxpDLcCxUQw2P1cObZLtiSxfoX3kDV7jsGG6RycEH0WtYYRBZ7uXazPR+ADSKlQ2FUsiqrDPWp+XaIhG3w1xN3QChOFqD7aRMhaVwohQ==;25:3M7XJKZotdL5PvSUBRZ6s+ffwCUkFp0QL3s/4ZjQYRTB5gu3MjsXAuIgrp56/fSDTpRiF/OWgoOOL1Vy9jR4WjhduYTzfrCYlR3eLYYDPuT4QzkYj2/uT2E3pUauO92MiruW7GOUBfGcdncXDH7pVXVZvJsb9tPE9s2OGuu6kHhg6YBdDFe9UTBbPx8aZEMFtYu/XFhHpRToUTfrjQ4+m1Hxj/UiYY0QIGKfscnd9gLMnCmjyw5eZM069ENU73kSWW2kZfAGdQvbbVkwn8VfBA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1727; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1727;20:L5Moz3rYluMavWlh9LdVdwwfcgUen/T9DcZv/W1avk67U4EoksdaxvgyQESI1KXEww1rv6VrZquR7H+USQMMG77x2PF8Pfbas3CatpWyylqnYIIpd0I+patyo2KK4LFy7bP+ebeq14UKxQlGyN66M2iupBefUWQFOLtSw/6yRwuhjWTNY67Y7lcsSl2zDBJ8uNgEP2lZEZCbuLxCbz13XwbJMQ8qmnvZXEbYzZOBU4eEFEY/aIGSJ+WQUKm506EUuejImJPZsxrUQNJ/lHrDAESwXTPd9SGiJKaaQ0ziy1YMpQk8bnQ1G7tbNtg+uGcn5KsFUEVATx2qvbaWHEWCTiyLUY5hIbJ9DQD27Bzu/ksIegZqaOSMA6DhaNCFvYX19nDmUMxS7XPghtg426mnj6D1nORsBtfchLbY+ruYyOgcNGXOOFZmci2nAwVYw0K0V/Vix2dpyvxVEYTBRli0YXK2zfrdd+bE0XpB0d6OPig/q7laxL8aU17PFruNncD3zqoS+ojwW5fdbi5DByqrCJB96zdGe52uSqgfO+kxc16FlBefZVaYLO4VVE/UtkZS+XArmHWsPWIdw7+y8Jy6KO35h0vwym5BTAS4AmgoSkc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:CY1PR0701MB1727;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1727; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1727;4:P+ttoCXltqPme8Gt7fH+aCMZSVv8B6lMdE/C5u7iPKbEfsTiwQj1N45AeryCmnvqgZSQS4tyO9UXYGYyq5W2XUleylRzPZIoyJW0JowJFjk+WmKIgjC/58bq5uTbW0zZ1Mm8yqcczoGjDpUscIFFQHu7CSL0if3rQnMyukOWGtfqltimxYpE+Hss2aShEwF9prf3wyeTQmBNCdRoFM0ip8YMCFVGOJjpj1hr+9ypGVwzJAUt6f+ip1Q2yQ+w+hRJPoChparvkeYrGpxyBTQ8+03FGOmgJObfClDQRTde+RGlDiSQB7q0hv59aocZH7CaIMJyWAxlzV/M6oSX7r9x1QHDsHZNRtXhyNoWVumDvZU= X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(479174004)(199003)(377454003)(24454002)(189998001)(5001860100001)(19580395003)(19580405001)(47776003)(64126003)(87976001)(80316001)(2950100001)(77096005)(4001350100001)(69596002)(66066001)(59896002)(81156007)(5001830100001)(23756003)(4001540100001)(65956001)(65806001)(97736004)(105586002)(110136002)(53416004)(50986999)(122386002)(77156002)(92566002)(106356001)(5004730100002)(36756003)(42186005)(64706001)(76176999)(5001960100002)(40100003)(46102003)(62966003)(54356999)(33656002)(5007970100001)(87266999)(101416001)(68736005)(50466002)(83506001)(65816999);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0701MB1727;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CY1PR0701MB1727;23:9UsxWV5jZ7m0zR2eX1Qhlb8bvcdSp0PMIEjxP?= =?iso-8859-1?Q?XTKR4jQn2XRD0XMRCocIy+fK1yeHYHi+3TfVeKmVwkLfRj6uR4YCHfAl5G?= =?iso-8859-1?Q?/dU0pH96pilEv3x+wc2O2b+GLL8OWuhp//+T2BcagYYcbi2hImsl18DVXV?= =?iso-8859-1?Q?exFWxfN7FqiFuc8uDL32H3hre4EUWKOVsG665akA0h6+e84Y7KMTid1R1b?= =?iso-8859-1?Q?Y8qJXKvCJ8bZoP334leUer+K+3ik6QYvfIjZ1N07aum1KToDkYABiWMFa9?= =?iso-8859-1?Q?iyjGqfuvwpJie2TDBTM2DE0NWtki+Ro2/wXOcr6wZi8fw0h9LAGlOBOxn/?= =?iso-8859-1?Q?7xED6aQKz6QcFy5XL6FW9X6SsXuMli7OHydIicyIFa3G0YWRaP+1iu2o2f?= =?iso-8859-1?Q?eLOPPP3eREXn0VhM4Sm8E+VP41oO2GqKXt0PewXiXHixRrJVabEUbTSWGM?= =?iso-8859-1?Q?MEzQHBEF0INA9oFe+WJE5yehobVWGgLG3/GMk8DFZkUDZKwJ0IrUA5SJVY?= =?iso-8859-1?Q?C0CjGcym6WKhP4DWIZbpDuYd2WrJ4PP/ARUUxXjb6PJIhWHVqoejj86ZOt?= =?iso-8859-1?Q?V3K/G0VTxFu75aFUP2MGxHTRgiCu9Js2dHDZaoFfEyeTjApACAAKAd1+77?= =?iso-8859-1?Q?TXxZIl2t2cV93vazOs3OgYQMtAmyDr+1csl1ONZTQ0mjXAnAKFKMIHj/Jn?= =?iso-8859-1?Q?0avTyCOQ5I6FzgVnU0mXtcb4/qKwnC+u+M8tInN1IAE3e1XIILq/maInvc?= =?iso-8859-1?Q?xrS/3vXD7Gfmgekcdn6Dqnm1ayo2t7wX0dQL39ydfSINuifhMB0HDdyuH4?= =?iso-8859-1?Q?DipXFNSKWzPITi6cwa5tJ/jdUKytvItQHuhvV2zB3s13PJ2sGoPJ5kSeg9?= =?iso-8859-1?Q?k2UuwR2KJGva9mEXc48/RTxVWYJYV7rJ87AhZX4qEvxalKq8IZBDjdk9o8?= =?iso-8859-1?Q?YBeNbXrxd0mbFmq0oFKewp2rbvUwpI/hKQzOR+qeKwFF6o2OSEKPNRKypO?= =?iso-8859-1?Q?W9LMCiwQHHsWD3MehldU5WeVGi/8NIgqBC8AXR9VC07om9e0dMLg9eIijZ?= =?iso-8859-1?Q?YYjVKFms21WfjmQVmcdACjh80fYnIUb/ADJ1m1rIG49loeYsoZIQWKj7dt?= =?iso-8859-1?Q?gn+6inGd0j3G8Ng/gciqOjxJCzUX3Qsm94Wbt1U0b7Zmz39q3CtvJ4ocB9?= =?iso-8859-1?Q?ayCzI76dUDw1/z0KYNSW06uRmIZrun5nZQP7TvV2kJ9Tm6YOnn1OeM/qh7?= =?iso-8859-1?Q?/2iAR8EBKB3hKQ831dZO0O2A/UdXkTo/0QLdwaHE5KOROnK/UI/GMq5p+/?= =?iso-8859-1?Q?UuM+X5GWZhY30BCe3Lt3hBoTbNlqiQkBDbFctmv68B0xc6dMXyUHkOAIBy?= =?iso-8859-1?Q?gd7h+r6NakYSxDE+jDlC2Dd1a8Jkp7oKGs4Hvy3BahLnp7SVD3rZ3Ir+PU?= =?iso-8859-1?Q?JvhxHsBThdAKRuZ7x1Y1a4hBM3uHUPm8+EV+L?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1727;5:a8QY9oFEgsg/bBImR+PnZW+VtCo/EGZUujkoH63rsq8bceI7DJncq2nSxX7UJ31N/HOiRRpi1qqGJ0SbIZC3rWWQp8ogeEqmY1vmDc2StSSUpkvl442ky9QHogHHseEjYASAav6nbMOCZpzeOX7yDA==;24:ve2h1pYbQ+Ixm0rpixJ0xsqpzCd1Vedpy67exwY7qmHSi8VDUWYyFAuLjdfd+w3sP0XbInM/ThsB6/EKVKSXcxsMdc5HnwY4ZuQctkgMwWY=;20:rOG14+jc7RbQyHa/co4c945Vg6SNhvfkusC7ZdxHKdmnLHIz/xbGYhSnhskVl4aAhRn4lYB2zbG1hbXOrb1O+A== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2015 17:08:43.1936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1727 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/2015 10:01 AM, Marc Zyngier wrote: > On Tue, 22 Sep 2015 17:00:06 -0700 > David Daney wrote: > >> From: David Daney >> >> Call of_msi_map_rid() to handle mapping of the requester id. >> >> Signed-off-by: David Daney >> --- >> drivers/irqchip/irq-gic-v3-its-pci-msi.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c >> index cf351c6..8b1c938 100644 >> --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c >> +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c >> @@ -86,7 +86,8 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev, >> pci_for_each_dma_alias(pdev, its_get_pci_alias, &dev_alias); >> >> /* ITS specific DeviceID, as the core ITS ignores dev. */ >> - info->scratchpad[0].ul = dev_alias.dev_id; >> + info->scratchpad[0].ul = of_msi_map_rid(dev, domain->of_node, >> + dev_alias.dev_id); >> >> return msi_info->ops->msi_prepare(domain->parent, >> dev, dev_alias.count, info); > > I really wonder if that shouldn't be part of the pci_for_each_dma_alias > call. It would make a lot more sense for this functionality to be an > integral part of the core code, and would probably make the integration > of _IORT (which has the exact same requirements) a bit easier. > > Thoughts? > I am a proponent of pushing things like this as far into the core code as possible. So, from that point of view, I think it would probably be a good idea. I can prepare a patch that does that, but it would also be nice hear from other maintainers and get their thoughts on this. > M. >