From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753999AbbIWSUP (ORCPT ); Wed, 23 Sep 2015 14:20:15 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:50038 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751935AbbIWSUN (ORCPT ); Wed, 23 Sep 2015 14:20:13 -0400 Subject: Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags To: Nishanth Menon , Santosh Shilimkar References: <1442938118-4718-1-git-send-email-nm@ti.com> <1442938118-4718-2-git-send-email-nm@ti.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: santosh shilimkar Organization: Oracle Corporation Message-ID: <5602ED34.9010108@oracle.com> Date: Wed, 23 Sep 2015 11:19:32 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442938118-4718-2-git-send-email-nm@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nishant, On 9/22/2015 9:08 AM, Nishanth Menon wrote: > Keystone2 devices are used on more platforms than just Texas > Instruments reference evaluation platforms called EVMs. Providing a > generic compatible "ti,keystone" is not sufficient to differentiate > various SoC definitions possible on various platforms. So, provide > compatible matches for each SoC family by itself. > > This allows SoC specific logic to be run time handled based on > of_machine_is_compatible("ti,k2hk") or as needed for the dependent > processor instead of needing to use board dependent compatibles that > are needed now. > > Signed-off-by: Nishanth Menon > --- You need to expand that 'not sufficient' for me. Unless there is genuine case to support this, I would want to avoid this churn. Regards, Santosh