From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754241AbbIWSs2 (ORCPT ); Wed, 23 Sep 2015 14:48:28 -0400 Received: from mail-by2on0092.outbound.protection.outlook.com ([207.46.100.92]:41664 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752741AbbIWSs0 (ORCPT ); Wed, 23 Sep 2015 14:48:26 -0400 X-Greylist: delayed 1579 seconds by postgrey-1.27 at vger.kernel.org; Wed, 23 Sep 2015 14:48:26 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <5602F3F2.2050100@caviumnetworks.com> Date: Wed, 23 Sep 2015 11:48:18 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Will Deacon CC: David Daney , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Marc Zyngier , Catalin Marinas , Bjorn Helgaas , "linux-pci@vger.kernel.org" , David Daney Subject: Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges. References: <1442966996-13419-1-git-send-email-ddaney.cavm@gmail.com> <20150923184005.GX7356@arm.com> In-Reply-To: <20150923184005.GX7356@arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: DM2PR07CA0014.namprd07.prod.outlook.com (10.141.52.142) To BN3PR0701MB1717.namprd07.prod.outlook.com (25.163.39.16) X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1717;2:72L5+wYNe7HuW1TvqJN3SOsMDEEt6SxHgvxmN9gL/IoOc7aOEEsrazmVIF0fZOpQevz8FQh4sVGthoG0maOvGKhCMBBZAjqn0O3/Sog1YjPmahz1E/N7Pr3jkKT06is+hoeu51q/hu3IXi501UouvCSpWe9wNF1iwp6CfjYeJ8s=;3:Hgn6ikS8GU3ycrmGGsQAwU9E9A/x0370t4Dp4n93LEpeWsH7iaNGX+2MoZ61ADsiL85SV/cEsSuq7hixMow9SdST11Dh3L0/08QHi7xrvIKaB9O3awPO4cWLuc5bF3L4Ooe4mVAlv4rceXMhrqyDDg==;25:MSqQqhol9YXEclEaLiBf8QkTEiOQh2VaB/rDFE1UV+IVsT4ofdJrV69AdKzTpqCvJscnSfBGkm7XoH1LjB5UFcWeOAdS5wgWlJbQ1J1L5nxYlJuMd/8rTG9i9ZygkQTdnQuofJMVO1ghLBqGVtq5cnAhY9tz/i4YZ1FieSWjYaw5sPnaC59nNw023xdcjaW5l/bsuTRe/YM7nG8bvt/w2If3g1HmmYDHCE3e7/e7j+UYztXCzO1gqFVfBA2nX+oy X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1717; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1717;20:p3AQf5ZdEKLyOwnaJRddB9pQZ+EFTJuLv53vJ/tTFNx+I/kVlGFKDzczAHJQwWsnSaGTDWYYZDMWLyp7t4VTfsErAfJ80zF8347MWA2s/Jadzsf6u2j2+mz/gd99GNJOGxkCbXlZ8LeJzew0EOV3A/f4bdoC0mUlZkAqvy2BmxcOfRtD8pStTXLj9KcoiaqlS5cuyAO5CI2vl40DB5I49PIqX41BVnWIPlRfswsF+GFVsqllOWFeeYZdhW7MGNejDkRh1lasHf4j0Q0GSQRJJZ4VTakVA1Zzf6LZLBpQg2ULy+ma8Scjf+CVsz/nTD9z7uBnOsJXnIatAHk+rP20ctlE/R266rUHz5wyZ7piicYewsF/MtOwwCaHPHfFVJkKb7NEHCC//7awvms6uYooudDvV+waTck3z5R6KLojkHDyosZoxF/ALS4UHWr+6rqGFTSUIRaGMvKdzPH4JjWeyA34B68L3CWrhjffIm5buJJ9SlL6zFkP2gEMLPkD6OM5bnT8h+5CTaAUomcMju9RE+0Wp5RW7LRXGoVJpeKKfw73w+TXMoKd1+S9YnOqJt3fLVDrjZMPGj3I7chb1UKCx+L8E4ny301QLmIy4rX1Op4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:BN3PR0701MB1717;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1717; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1717;4:I9+lZa5yE4JaKE8zWsedfYgUWMBl0vXZQn+wDG1CPcZcemjKRZpjGx7JHrG+NJMyU982F7vUmuwdHuTuKlNKtRLFbg2BeON8UiINQ5kuq7vD3lIOXPcIXXzNFMR0sm4HcLkTpSMHWpHaZa+mTzMDdTWU+CkPY/bfiLp6/IEe9k28Yuc5bLLMVDWH7Rkr2W0sSNlagrU2Zg0fnuLWYWOmdJkVpmlqan2VDnRz8s1+R5nr4laoyTv5TE5KaZEJQAyRNyedgjlesdUfyvsSAc/sj8NodikWufOLb8gw+8WXzrouFRxhyCR3b1FaDNq0yTLI8K/n+OmxcKnh8Jz38TxbmTHxbRPigbQP5TGN36TSgWM= X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(199003)(479174004)(377454003)(189002)(50986999)(87976001)(64706001)(101416001)(83506001)(62966003)(77156002)(40100003)(68736005)(23756003)(66066001)(47776003)(87266999)(105586002)(122386002)(69596002)(64126003)(2950100001)(92566002)(65806001)(106356001)(36756003)(76176999)(65956001)(5007970100001)(5001830100001)(97736004)(54356999)(50466002)(80316001)(4001540100001)(53416004)(5001960100002)(19580405001)(110136002)(59896002)(19580395003)(81156007)(77096005)(42186005)(5004730100002)(33656002)(4001350100001)(65816999)(189998001)(5001860100001)(46102003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1717;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN3PR0701MB1717;23:0jCsCIdzgnXo9tNtSRxD942VxDMzSKyG+JGaR?= =?iso-8859-1?Q?mRdZPH7zOReJ22Ma21TEanCQ5zNdWSFGYyoWGnwAuYcvAiQNtVnmbTUh0/?= =?iso-8859-1?Q?Tm/6+TxxOeLut6Snhe6+ytFBmIMxVzTI+ghtlQXfmIlpEAOMvy/S7FFn5A?= =?iso-8859-1?Q?FDp1POp/NelhUDoIm1GG0+jGDXsh1QaOIEcWqtkqTJQgmbJw0AwdUF/AT2?= =?iso-8859-1?Q?QQHVQhxKQZwCxsL4rwhuxLzq4eRipo8/RTf3l7BZ5wPoWNXqeGhBMC4mm3?= =?iso-8859-1?Q?9vzejM8oL5+x5mu3LEu4kF5Ee/bSvgMD9OBvLMezsKXIFTmmRcxfy6yaqR?= =?iso-8859-1?Q?r17XQ6A4lSoRg5KopDBRFRSJKCYWdrJG841A2eS9F7u2G8MXcaipxxEDBU?= =?iso-8859-1?Q?YrcnZkmwh2zhU7YtEwyLpzAM3wAqElyYpcaOQYzuAivt7CNx139J7eSfNE?= =?iso-8859-1?Q?DeBIYZzazhTQQJ2kDf1u+Hb7viozP98/16g1TAzdIPtHZqtZ/p72LFtbl4?= =?iso-8859-1?Q?GHzq7Kj+qqfDd9k6Lw4CHT3+JCNQ8V/L/D8OTVoxVjC0bvEsaBdqt964YW?= =?iso-8859-1?Q?LJyjT57wsfjM7k6bXWqvMWdm+17+iJxc8lxFwZ0uPRIQ3V6NljNxfH5y9r?= =?iso-8859-1?Q?V/bcyAQ83qaYXEBLdtRZglTfGCdNkoXOHUUhXRsS6GwrUuPQuvDpOdptqR?= =?iso-8859-1?Q?Zq+0USBzKpN49cgJoSHa6BLM/FIKteSCHZ7XR1t345TmnmKKcYHfwXLE+1?= =?iso-8859-1?Q?j5yoMl1fbaj2sl/lX3QgCP95PHrHSt6VZ3hzqWNpNBFCxwdd61zYZk6ag1?= =?iso-8859-1?Q?P52dckhB76aDOAfSqmjG02nJ0oe6CorbiD7HTa1dCh7yqOPlEd3Lah4Q6e?= =?iso-8859-1?Q?u4rXyjUxTT7dXwJUGuoC2QPblDgpBy+JWHnKSLbWOx4/J6CbLGO5mEV+Cp?= =?iso-8859-1?Q?Zrz7j3g9xxCux7Ac5JAlvHPYDJ/DnNGABr2aIvsdvD8uO4Gb0QC9XHiwzS?= =?iso-8859-1?Q?Cm4bkzZB7/6jbXG4igq9wo4NGUR/CIeyAI/b5oPHqse1D1VLIKqILGP70K?= =?iso-8859-1?Q?LUGTbBoAUt9bfZNoNKnsyw1vB47USjCurIPZBxACocLYHL+spsOSpYmRWv?= =?iso-8859-1?Q?oyX17XuDAYhEeGo/CdUcZ8d1UsBd9Fp0g1bs8EKC7GX36ElCvwRrxxBCOQ?= =?iso-8859-1?Q?ulAJNb9/g1hTUWJf3rdwiIQOdSj7gnGprNlBJhd7Rrto/L8sGemsotiUeB?= =?iso-8859-1?Q?VNrWaKgFn28hToODJq7yw8+xRFwqn1rSL2iye5+LgCcpxKxEAi4qgyluhg?= =?iso-8859-1?Q?jXc2TZt4bV8MzS9Ke2N9dRINpTmApa90MRTxJfnB06zo+dpRr7248Rb8lG?= =?iso-8859-1?Q?RO3V+0NGB/fqO64JAKjXhjiAikZIH5zQ1wz3DuiFanEfPEbeOCIPSpwIvT?= =?iso-8859-1?Q?aUwNBU3705gMuL0nLHgmi7YV11IF0C4ZIdvu7?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1717;5:Y7XJgk/RVoAmEs6FqoBbrD7j2Stcyfe76JIOOq3Ok0jw1vGOEBk30FwRwxliR/5P3rH6T1zu5zQWu5mexirn3I1cG0nUIKhmUykqFEHmcg1SJ/RmXAPBRl4/mWJy/zujWRsolMWWLrc5l7xuFXSInw==;24:Ig6IFrg3wrwJ+kX9i10Lx9RhhAJiAw0yz6fqrOoO4dg68gx5MdXVbbz6LbrCgS7JivNNoBqGFDQMVLoT3BkgkxFsxFIb6/h51uyfNPup/eM=;20:hpZZARAmgT614NnYCH4Mki0kkKoOFmvfr+FT4/pGMramIqcvdlQaCa9+pNRN9yMVcTo3Gg1IpZd3CQD/43P6UQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2015 18:48:22.7414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1717 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/2015 11:40 AM, Will Deacon wrote: > On Wed, Sep 23, 2015 at 01:09:56AM +0100, David Daney wrote: >> From: David Daney >> >> The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges. >> Since it is arm64, create a new quirks.c file there to contain arm64 >> related quirks. Add the ThunderX bridge quirk, gated by a new config >> variable, so that it can be disabled for kernels that aren't expected >> to be used on ThunderX. >> >> Signed-off-by: David Daney >> --- >> arch/arm64/Kconfig | 11 +++++++++++ >> arch/arm64/kernel/Makefile | 2 +- >> arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 48 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm64/kernel/quirks.c > > Why does this have to live in the arch/arm64/ directory? The quirks have > nothing to do with the architecture code. > It doesn't have to live there. It is something that will never be used for any other architecture. So I thought we could do like arch/x86/kernel/quirks.c I could move it to drivers/pci/quirks.c if people think that is a much better place for it. David Daney