From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932504AbbIXCJk (ORCPT ); Wed, 23 Sep 2015 22:09:40 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:52106 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932250AbbIXCJg (ORCPT ); Wed, 23 Sep 2015 22:09:36 -0400 Message-ID: <56035A71.9040301@huawei.com> Date: Thu, 24 Sep 2015 10:05:37 +0800 From: "long.wanglong" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Michael Ellerman CC: , , , , , , , , , , , , , Subject: Re: [PATCH] kselftest: using built-in rule when delete file References: <1443001211-119624-1-git-send-email-long.wanglong@huawei.com> <1443059210.21433.1.camel@ellerman.id.au> In-Reply-To: <1443059210.21433.1.camel@ellerman.id.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.111.152.157] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/9/24 9:46, Michael Ellerman wrote: > On Wed, 2015-09-23 at 09:40 +0000, Wang Long wrote: >> Use make's built-in rules to when delete a file >> or delete files. > > It's not a built-in rule, it's a variable. Sorry，I did not describe clearly. It is a variable used as name of program in built-in rules. > > Personally I think using rm directly is clearer, but I guess this is fine. Do > you actually want to override $RM ? > So far, I do not want to override $(RM). But I found that some test's Makefile using *$(RM)* while the other's using *rm -f*, I think it is better to use one of them in all unit tests. Do you think which one is better? Best Regards Wang Long > cheers > > > > . >