From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754904AbbIXPKT (ORCPT ); Thu, 24 Sep 2015 11:10:19 -0400 Received: from mail-ig0-f179.google.com ([209.85.213.179]:38162 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752526AbbIXPKP (ORCPT ); Thu, 24 Sep 2015 11:10:15 -0400 Subject: Re: [PATCH] powercap / RAPL : remove dependency on iosf_mbi To: Pengyu Ma , Jacob Pan References: <1442475101-1872-1-git-send-email-pengyu.ma@windriver.com> <1542119.JQ7HNYzFZu@vostro.rjw.lan> <20150918084356.4bf149a6@yairi> <55FF7DFE.8050906@windriver.com> <20150921143629.4f597e1c@icelake> <5600C6E8.50602@windriver.com> <20150922100149.36ae0251@icelake> <5603CA74.8010201@windriver.com> Cc: "Rafael J. Wysocki" , rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org, "Box, David E" , "Anvin, H Peter" From: Austin S Hemmelgarn Message-ID: <5604123E.2020605@gmail.com> Date: Thu, 24 Sep 2015 11:09:50 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5603CA74.8010201@windriver.com> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-512; boundary="------------ms080805030304040602010000" X-Antivirus: avast! (VPS 150924-0, 2015-09-24), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms080805030304040602010000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 2015-09-24 06:03, Pengyu Ma wrote: > > > On 09/23/2015 01:01 AM, Jacob Pan wrote: >> On Tue, 22 Sep 2015 11:11:36 +0800 >> Pengyu Ma wrote: >> >>> >>> On 09/22/2015 05:36 AM, Jacob Pan wrote: >>>> On Mon, 21 Sep 2015 11:48:14 +0800 >>>> Pengyu Ma wrote: >>>> >>>>> On 09/18/2015 11:43 PM, Jacob Pan wrote: >>>>>> On Fri, 18 Sep 2015 02:09:55 +0200 >>>>>> "Rafael J. Wysocki" wrote: >>>>>> >>>>>>> On Thursday, September 17, 2015 03:31:41 PM Pengyu Ma wrote: >>>>>>>> iosf_mbi is supported on Quark, Braswell, Baytrail and some Atom= >>>>>>>> SoC, but RAPL is not limited to these SoC, it supports almost >>>>>>>> Intel CPUs. Remove this dependece to make RAPL support more >>>>>>>> Intel CPUs. >>>>>>>> >>>>>>>> Please select IOSF_MBI on Atom SoCs. >>>>>>>> >>>>>> Unlike Quark, I don't think we want to or do differentiate Atom >>>>>> from other x86 at compile time. IOSF driver can be compiled as a >>>>>> module also, therefore RAPL driver needs this explicit dependency >>>>>> at compile time. >>>>> As commit had exported iosf_mbi to let user use it. >>>>> >>>>> commit aa8e4f22ab7773352ba3895597189b8097f2c307 >>>>> Author: David E. Box >>>>> Date: Wed Aug 27 14:40:39 2014 -0700 >>>>> >>>>> x86/iosf: Add Kconfig prompt for IOSF_MBI selection >>>>> >>>>> >>>>> While selecting IOSF_MBI is preferred, it does mean carrying extra >>>>> code on non-SoC architectures. >>>>> >>>>> We can NOT force user to build in iosf_mbi if they want use RAPL on= >>>>> haswell/broadwell/skylake. >>>>> And RAPL can be compiled and worked well on >>>>> haswell/broadwell/skylake without IOSF_MBI. >>>>> RAPL is really NOT depended on IOSF_MBI. >>>>> >>>> True for haswell/broadwell/skylake platforms. But if we want binary >>>> compatibility for Atom and Core, I can' see how simply removing the >>>> dependency would work, unless we have runtime detection of IOSF. >>> If you want use iosf_mbi on atom, please select it on generic x86 >>> config. But not force it depend on another feature that not related >>> on it with other boards. >>> I don't care how iosf_mbi is added to kernel config, but why should I= >>> be forced to add it if I want use RAPL? >>> It doesn't make any sense. >>> >> I understand your concern about wasting code. But let's look at all th= e >> cases of config options here. (without Kconfig dependency as you >> suggested) >> >> RAPL\IOSF Y M N >> ___________________________________________________ >> Y OK DC* Warn on Atom** >> M OK OK Warn on Atom >> N OK OK OK >> ___________________________________________________ >> >> Notes: >> * DC: don't compile >> ** Warn on Atom is runtime if I add the following code to RAPL driver,= >> but this case is ok. >> >> --- a/drivers/powercap/intel_rapl.c >> +++ b/drivers/powercap/intel_rapl.c >> @@ -982,6 +982,11 @@ static void set_floor_freq_atom(struct rapl_domai= n >> *rd, bool enable) static u32 power_ctrl_orig_val; >> u32 mdata; >> + if (!iosf_mbi_available()) { >> + pr_warn("No IOSF MBI access to set floor frequency\n")= ; >> + return; >> + } >> + >> >> So the problematic case is when RAPL=3DY IOSF=3DM >> Since real IOSF functions are available when >> #if IS_ENABLED(CONFIG_IOSF_MBI) >> There will be no dummy functions for RAPL to reference in this case. > iosf_mbi_write/read will warn itself. >> Since IOSF is a driver, making it a module is a reasonable requirement= =2E >> As I mentioned before, I don't think we want to have a CONFIG_ATOM >> option for X86. > Actually there is a CONFIG_MATOM already in Kconfig.cpu That's for code optimization (it changes compiler flags), not=20 determining what system we're actually building for, and on top of that=20 it's for older atom processors, not the new ones. It's fully possible=20 to build a kernel for an Atom processor without selecting this. > > Pengyu >> >> +David, HPA >> >> Jacob >> >>> Pengyu >>> >>>>> Pengyu >>>>>>>> Signed-off-by: Pengyu Ma >>>>>>> Jacob? >>>>>>> >>>>>>>> --- >>>>>>>> drivers/powercap/Kconfig | 2 +- >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/drivers/powercap/Kconfig b/drivers/powercap/Kconfig= >>>>>>>> index 85727ef..a7c81b5 100644 >>>>>>>> --- a/drivers/powercap/Kconfig >>>>>>>> +++ b/drivers/powercap/Kconfig >>>>>>>> @@ -17,7 +17,7 @@ if POWERCAP >>>>>>>> # Client driver configurations go here. >>>>>>>> config INTEL_RAPL >>>>>>>> tristate "Intel RAPL Support" >>>>>>>> - depends on X86 && IOSF_MBI >>>>>>>> + depends on X86 >>>>>>>> default n >>>>>>>> ---help--- >>>>>>>> This enables support for the Intel Running Average >>>>>>>> Power Limit (RAPL) >>>>>>>> >>>>>> [Jacob Pan] >>>> [Jacob Pan] >> [Jacob Pan] > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel"= in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ --------------ms080805030304040602010000 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgMFADCABgkqhkiG9w0BBwEAAKCC Brgwgga0MIIEnKADAgECAgMRLfgwDQYJKoZIhvcNAQENBQAweTEQMA4GA1UEChMHUm9vdCBD QTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNp Z25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcwHhcN MTUwOTIxMTEzNTEzWhcNMTYwMzE5MTEzNTEzWjBjMRgwFgYDVQQDEw9DQWNlcnQgV29UIFVz ZXIxIzAhBgkqhkiG9w0BCQEWFGFoZmVycm9pbjdAZ21haWwuY29tMSIwIAYJKoZIhvcNAQkB FhNhaGVtbWVsZ0BvaGlvZ3QuY29tMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA nQ/81tq0QBQi5w316VsVNfjg6kVVIMx760TuwA1MUaNQgQ3NyUl+UyFtjhpkNwwChjgAqfGd LIMTHAdObcwGfzO5uI2o1a8MHVQna8FRsU3QGouysIOGQlX8jFYXMKPEdnlt0GoQcd+BtESr pivbGWUEkPs1CwM6WOrs+09bAJP3qzKIr0VxervFrzrC5Dg9Rf18r9WXHElBuWHg4GYHNJ2V Ab8iKc10h44FnqxZK8RDN8ts/xX93i9bIBmHnFfyNRfiOUtNVeynJbf6kVtdHP+CRBkXCNRZ qyQT7gbTGD24P92PS2UTmDfplSBcWcTn65o3xWfesbf02jF6PL3BCrVnDRI4RgYxG3zFBJuG qvMoEODLhHKSXPAyQhwZINigZNdw5G1NqjXqUw+lIqdQvoPijK9J3eijiakh9u2bjWOMaleI SMRR6XsdM2O5qun1dqOrCgRkM0XSNtBQ2JjY7CycIx+qifJWsRaYWZz0aQU4ZrtAI7gVhO9h pyNaAGjvm7PdjEBiXq57e4QcgpwzvNlv8pG1c/hnt0msfDWNJtl3b6elhQ2Pz4w/QnWifZ8E BrFEmjeeJa2dqjE3giPVWrsH+lOvQQONsYJOuVb8b0zao4vrWeGmW2q2e3pdv0Axzm/60cJQ haZUv8+JdX9ZzqxOm5w5eUQSclt84u+D+hsCAwEAAaOCAVkwggFVMAwGA1UdEwEB/wQCMAAw VgYJYIZIAYb4QgENBEkWR1RvIGdldCB5b3VyIG93biBjZXJ0aWZpY2F0ZSBmb3IgRlJFRSBo ZWFkIG92ZXIgdG8gaHR0cDovL3d3dy5DQWNlcnQub3JnMA4GA1UdDwEB/wQEAwIDqDBABgNV HSUEOTA3BggrBgEFBQcDBAYIKwYBBQUHAwIGCisGAQQBgjcKAwQGCisGAQQBgjcKAwMGCWCG SAGG+EIEATAyBggrBgEFBQcBAQQmMCQwIgYIKwYBBQUHMAGGFmh0dHA6Ly9vY3NwLmNhY2Vy dC5vcmcwMQYDVR0fBCowKDAmoCSgIoYgaHR0cDovL2NybC5jYWNlcnQub3JnL3Jldm9rZS5j cmwwNAYDVR0RBC0wK4EUYWhmZXJyb2luN0BnbWFpbC5jb22BE2FoZW1tZWxnQG9oaW9ndC5j b20wDQYJKoZIhvcNAQENBQADggIBADMnxtSLiIunh/TQcjnRdf63yf2D8jMtYUm4yDoCF++J jCXbPQBGrpCEHztlNSGIkF3PH7ohKZvlqF4XePWxpY9dkr/pNyCF1PRkwxUURqvuHXbu8Lwn 8D3U2HeOEU3KmrfEo65DcbanJCMTTW7+mU9lZICPP7ZA9/zB+L0Gm1UNFZ6AU50N/86vjQfY WgkCd6dZD4rQ5y8L+d/lRbJW7ZGEQw1bSFVTRpkxxDTOwXH4/GpQfnfqTAtQuJ1CsKT12e+H NSD/RUWGTr289dA3P4nunBlz7qfvKamxPymHeBEUcuICKkL9/OZrnuYnGROFwcdvfjGE5iLB kjp/ttrY4aaVW5EsLASNgiRmA6mbgEAMlw3RwVx0sVelbiIAJg9Twzk4Ct6U9uBKiJ8S0sS2 8RCSyTmCRhJs0vvva5W9QUFGmp5kyFQEoSfBRJlbZfGX2ehI2Hi3U2/PMUm2ONuQG1E+a0AP u7I0NJc/Xil7rqR0gdbfkbWp0a+8dAvaM6J00aIcNo+HkcQkUgtfrw+C2Oyl3q8IjivGXZqT 5UdGUb2KujLjqjG91Dun3/RJ/qgQlotH7WkVBs7YJVTCxfkdN36rToPcnMYOI30FWa0Q06gn F6gUv9/mo6riv3A5bem/BdbgaJoPnWQD9D8wSyci9G4LKC+HQAMdLmGoeZfpJzKHMYIE0TCC BM0CAQEwgYAweTEQMA4GA1UEChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNl cnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcN AQkBFhJzdXBwb3J0QGNhY2VydC5vcmcCAxEt+DANBglghkgBZQMEAgMFAKCCAiEwGAYJKoZI hvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTUwOTI0MTUwOTUwWjBPBgkq hkiG9w0BCQQxQgRAZ8W29urm9AnO7zn67wCkN0UQAhQOppwE2rMFRM9MnokJ1czKr6EmhIDO VCHzJJxzXWYalcMewMM1cAZ/W0gV5zBsBgkqhkiG9w0BCQ8xXzBdMAsGCWCGSAFlAwQBKjAL BglghkgBZQMEAQIwCgYIKoZIhvcNAwcwDgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3DQMCAgFA MAcGBSsOAwIHMA0GCCqGSIb3DQMCAgEoMIGRBgkrBgEEAYI3EAQxgYMwgYAweTEQMA4GA1UE ChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlD QSBDZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2Vy dC5vcmcCAxEt+DCBkwYLKoZIhvcNAQkQAgsxgYOggYAweTEQMA4GA1UEChMHUm9vdCBDQTEe MBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNpZ25p bmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcCAxEt+DAN BgkqhkiG9w0BAQEFAASCAgATz2qlqS8dM/CPNSI1e0x2xzmnAhL5Z5JVBly76JwLqOWsMQy/ XBMlbcHoNIDExAYLTK96qYr27DjuKGx4HdSwqZGvYCowdko6qUPfgJBmDskLesFkcXOKRt40 2F05n7ucuiu2wgWdyATVAjU1BKhbol5SfCbu9AmJDlZDXEv0j8Fm2ztni9DSKsqpuJ8+L38y CszSPnKdqF4jx5KbBa1hb4bSw5d+x1cZ9VtjHNM6up7l36PxVB2bYxjI4O1HpCSWSwwkP6X3 2+9HltihmRUupBOMEnCFS63qWsVqOVBLzUfnGIH6XlmbiDNtCEtBlWH4Vi47/ufzqPqiWyg8 PYCWczZaKtFZFhDqxMDHo6JsYI7ROJAPH8Q3cTLjnuIjiXluouuVvQJdnVSqOPbO93UIUPUp QcdupPJfQrRR6H63Y5cTcAJdFmUAvJ7w5JiYsu6X1VzYd7wyZkBi51PUiB3HALVvYy9OKBJD H9y4eFS6yFvuGugkFQiBT4uoqeqwW52sWkpsByEuPNO/YgoOasl3kutwHr0DeFLSuD4kE+nq AEgTm25pl9ngDRfaa+b17uo1VmsYEA2dIGco4ioWcTV4aGviqYC5PkDpt2ubIqEpwIN7hnZd DpGJ7PdbLbsnnztyjP1ZAxnC2kovqwyKrZ11RAATTAL9XpXTBrNWdC30FgAAAAAAAA== --------------ms080805030304040602010000--