Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]


On 24/09/15 18:36, Luis de Bethencourt wrote:

> I am a bit confused.

Yes, it's an interesting mess due to legacy reasons. Maybe we manage to
fix it some day...

> So how the OMAP DRM auto loading is supposed to work when using Device Trees?

omapdrm isn't a real HW device driver at the moment. There's another
driver, omapdss, which is the HW driver, and omapdrm uses omapdss.
omapdrm platform device is created by omap platform code at boot time,
the same way for both DT and non-DT boots.

> As far as I can tell, the main omap drm driver does not have a OF device ID
> table and a .of_match it only has a MODULE_ALIAS("platform:" DRIVER_NAME),
> but the tiler driver (that is built-in the omap drm driver) does have a a
> OF device ID table and I see in DTS that are device nodes using those compatible
> strings
> 
> $ git grep omap4-dmm arch/arm/boot/dts/omap*
> arch/arm/boot/dts/omap4.dtsi:                   compatible = "ti,omap4-dmm";
> 
> Does that mean there is no need for MODULE_ALIAS("platform:" DMM_DRIVER_NAME)?

No, I think that's the thing that makes omapdrm load.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]