From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756911AbbIXPve (ORCPT <rfc822;w@1wt.eu>);
	Thu, 24 Sep 2015 11:51:34 -0400
Received: from mout.web.de ([212.227.15.3]:50649 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754410AbbIXPvc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 24 Sep 2015 11:51:32 -0400
Subject: Re: [PATCH] coccinelle: assign signed result to unsigned variable
To: Andrzej Hajda <a.hajda@samsung.com>
References: <1443099286-16559-1-git-send-email-a.hajda@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Michal Marek <mmarek@suse.com>, Nicolas Palix <nicolas.palix@imag.fr>,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        cocci@systeme.lip6.fr
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <56041BE5.5010005@users.sourceforge.net>
Date: Thu, 24 Sep 2015 17:51:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1443099286-16559-1-git-send-email-a.hajda@samsung.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:Z++AUyymGmAm7Bw52kHMH82tTidWFooE+deBb8D7mphawxLDbAe
 2H4aKyU6miYPP9QmaGZwSA6u4m2SWFMnniR5NzaYsRyBWIeAB939FuViH5tqsdXIPA4VlLq
 RmJS98b1vhpJ0EmzuEkEa8Dt65oeMjHGoC/3zo/quu6fWABUOhzWp1ehtr4ny59xeayKjgx
 +/9CIuRWwRtPfIaOGW6vg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:xUBhFfqpeDs=:IKur5wAEcxFrR0YiL39qQx
 A+WZSp6YaItiGd4c9plQlOcEgnrisFnP6pL82FaC94P5C9hDvIgqyNy/Zma82QnHSucblNEp/
 iGqNHijABmgzyEoCLETSEMjT5hgGC0JO48s1i8ALFWgaHoS6POuG/7VAjelQ6BnuL+Xq8yQEt
 yg6MHIQnK6JpmqyV+MVdIWDzWKu0LrTyuYuYZ7cwDviJNNiAs45i8gIutCVaEbpOlrVE4lUdv
 ufzk12AZ3QMws3U3HZLCAaKQ5h0/1UzGnMal9PbBpz6DXbkUttmLHS7510p1xkzC2lwjej4Q1
 R2JsGQxtHEVOVZM7Cr5fhodTxsWpQqseK7RJ2a/hL+VfNnMFRD9J//N3TcdjwEZdEL5w/6mbq
 07U4d1+KmTZL65AQhdPSJPk46nGrMnnouJlpsvfrValZQVWO7efcAvuL0JI1vysGLjHMWufu2
 7SHQUVlUacmClw8/WlF4/HuwEJvnQsIJnpHp57q+IdCFcte6jM5d9O6fgxIMsbX8b6rxUJ29G
 QxKG8826yfeIME6dHi06K3H6JSUcjjtovjI53ZhzcBUn/bGH6fFT6+OEQeTeMdqRKTL05EvFD
 HkEh9sbeO0M1hS4cLnuaBGvys8fCiMP9QhIQgf9JcYXanmYJHGj9hALImA9XVtzlua5Gm6vBq
 vpL3f4pHC/RmCCziheEZYx4fZfp+8EpXQXuA6oINFX7RigReCJBVOKNbD94iZcqkXT2IKQ6QS
 Wh8CcVsmENC7wmTDPmuzkT6b9KzSsA+30yPoFA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +@rs@
> +position p;
> +typedef bool, u8, u16, u32, u64, s8, s16, s32, s64;
> +{char, short int, int, long, long long, s8, s16, s32, s64} vs;

Can it matter to specify also the type modifier "signed" in this SmPL approach?
http://coccinelle.lip6.fr/docs/main_grammar005.html#ctype_qualif


> +{unsigned char, unsigned short, unsigned int, unsigned long, unsigned long long, size_t, bool, u8, u16, u32, u64} vu;

How do you think about to reformat such a data type enumeration?


> +@@
> +
> +vu@p = vs
> +
> +@r@
> +position rs.p;
> +identifier v, f;
> +statement S1, S2;
> +expression e;
> +@@
> +
> +*v@p = f(...);

Do you try to check here if the value receiver is at the same source code
position from the SmPL rule "rs"?

Regards,
Markus