From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755170AbbIXQm3 (ORCPT ); Thu, 24 Sep 2015 12:42:29 -0400 Received: from mail-bn1on0074.outbound.protection.outlook.com ([157.56.110.74]:65303 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751591AbbIXQm0 (ORCPT ); Thu, 24 Sep 2015 12:42:26 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NV6X2L-08-A3L-02 X-M-MSG: Subject: Re: [PATCH 2/3] EDAC, amd64_edac: Extend scrub rate programmability feature for F15hM60h To: Borislav Petkov References: <1442436811-23382-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1442436811-23382-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <20150924091841.GA3457@pd.tnic> <5604218C.7020905@amd.com> <20150924163314.GE3774@pd.tnic> CC: , , , From: Aravind Gopalakrishnan Message-ID: <560427EC.7050706@amd.com> Date: Thu, 24 Sep 2015 11:42:20 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150924163314.GE3774@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(479174004)(24454002)(189002)(164054003)(377454003)(199003)(33656002)(5001860100001)(46102003)(23676002)(80316001)(93886004)(64126003)(83506001)(47776003)(65956001)(65806001)(64706001)(87936001)(86362001)(36756003)(11100500001)(77096005)(4001540100001)(87266999)(65816999)(101416001)(4001350100001)(54356999)(5001830100001)(76176999)(97736004)(59896002)(99136001)(50986999)(68736005)(50466002)(106466001)(77156002)(62966003)(110136002)(2950100001)(189998001)(5004730100002)(92566002)(105586002)(5007970100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR12MB0850;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;2:rmeJ1fTeDEZxri49vq1hKreCQiiP0SXFpp2kmFoKLiMBz+FaMZDz4ChrLQ78G5mFMWRr7l+mtdQ3ZiVbuVkqxm8t/2lsIUPtCrkaCA7b/x0nptr/a4g+h48jjyQIvLEQCKs0CCodG3+X3JlUo/bi3rosnt+UhPXkZKX9aE4aVDs=;3:rwuh7uJPCOKS7gAGbjsQGjVt3MD2hFKPGSdzaSGzno3o1WOvuUbMhe1x1rxLqOnZUiJ5U/ONa4U7rJ7BwT3wZhGqyD6VlkAsYx7pHs3QJoBD6dVhdm41K/9ewOEsG8Ac8dgB2m+5JEK62jgXc8eZL3CSSSsiwmhcK+4iRkULv75I6EuPV+x+++Dnfx1RRxpdzi047EvCI/21eHbkRNC3SFP24GxGMb7Q3NRsU08BM9l3tSiZRdhc51HCmEngrMor;25:P5uV5jquOtv+DwvB9hVS4DljCxXrcY43md8lL+p4tpQxU5QE5gcuacQ5cxwsw5ZSaDXfqBU1N4nSeMb9JDKPRL2ePfNDX9uBd8P9juq1qgSbfsbPm35ySoP7KR/rHAoyRQLHV//ehdyFwUn6/m1Z+5hxLK+KiGWZcsovc1rBfan1aDK4vjuLpqZaQjXrxdpFbeGrgCx/cNAaT6rqk0NqiAp1ctTYRvKd5MzC/HmEELwwf7J18ohMZ95+B3Y3HVlHuTqi1jszYZwZ+KjgCI2kLA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0850; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;20:uBGgnluvpen6vS+Xplaz2EbNHUxChnRJyys9qcDgQWIQzAonx4NHoI3iYpUfiu8b6jNMi9sxKz9SccukkhGagGVjVSa1JLCfF8ze+U42A4cfSKOuxbPVCviKnYW4C+02mlYuV7sQp/CxS/sYW3mj/fUM4WdVdEqwg9XTNiW9kqgzT5xvhZokjHY/O9TuuPhJ7io956TKGBoxC2MWwxBO2xup+j/yVtSbh+sjL0y4rNZAn09UYePl+YEdnT+IddFoz0jlFFf+R88eyqlQ/QihnNjFfiJFFC85KiAvg3P+PGBrsEbUmXcpKsk7W9HzD23JPfIzwvoL4h1lSNEFqFl+LAeMI9cJJ7x/g/8az9sRP3tlYEo2QR1dNmY0tnlIjOJ1iXLrFx/WEpV7i7FcHFh8rMKgoxGMgPFjch2UAwtpJ9ZDskh6LJi6scA6R9cFnlB2ssx4WaIkkoi7eUt9wiMm6Fd+XIs268ME/H489RNZtS8o/L32itkFc4nxLABW/67d;4:uhWO8fjuuI0dYtfh6eUqe9hziXcG7FR4VZy2w+0Syc5bTIGKL916Qe2oNBIDm5rTphrA6ibqnyWgv63BtXite47d7mO0te4M/5fcC7qxSR7i5fgbKn9OgrTUgtypPGNcxzvnNSTJsHu6naiqflSeAl/sleI/GAQjSB8Nj7b+ZxhABurENKCLanoJQnyFJU35fIUoKH26ApOTu7D+KRcG66L0sOf4XiVsmwZpEkfqGJdycTbdwOTPvFXgPO8EXI49mI/78k9mELbjySHNwHVVT5fbaV/Mu6y3dQa+WbksM3sZD2ovCKJALVcJaGHC1X2GlBNQUmzwmKoBAPuMf7p3OcI594EjbShVHFNPf178EhU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:BN4PR12MB0850;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0850; X-Forefront-PRVS: 070912876F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjRQUjEyTUIwODUwOzIzOjY3SmRoRHZJTW9FQVFXS2FxWkVEVzJzVFNu?= =?utf-8?B?elQ4SWd4T3lNTGVJYzc0cm53ZVFyeU11M2U1WTNKbVN2SHRRVmlZWmJrYlN4?= =?utf-8?B?NWN6UVo4b1VwTUN1NytuM2J2YkdLRlBldEo3SitDS29SeTZ4SWM5c0hKNUla?= =?utf-8?B?cTFKWVBLZk4rcWFNTWxhZFVrUHYrTnVDVkJCeGpyczc4NlB3aUI1TDIvVW4w?= =?utf-8?B?eC9nT3pQQmpPWWJXM0k3TkZ0U2lKaUNZSWJINE9mMVpubEpOenRRbW42NXVx?= =?utf-8?B?alROdGlQbVhzRmFGZzdoZXJPQTA0bXRYQmlCYlZuUWdFT0Jkclh0Rnh0NDVy?= =?utf-8?B?eGV4a3RUQ1h2dkRURmZMMnZUWHZEZzhPdnplWDdENXFTNXhOanh0elMzdWF1?= =?utf-8?B?ZXhPVk1SVUxPdmcrMGcrVXkxU2FnOWpXYnBpa3lWYnpRS0QwNUp6YnBSOUZl?= =?utf-8?B?VlVyQ0VlMDNXc1NqOTRUQy9KY0hrWjVWTW1kMlFNb3JQSjU2R1F1Uytveit3?= =?utf-8?B?UmF2dkE3MS8rRkE3MEFPc0NleEpaaS8rdG82Qnk0NzlBN1FQOHQ2eEFYWGxs?= =?utf-8?B?L0RHeU13Ryt6WHNSQzJ4ZWF2bzJxRGFXVmZzZGlHTjhLYkFiRzlYZzFCVnVi?= =?utf-8?B?SGNzQTBpdDZuWkJ5NnVWczBlak5vZndpbUozUURBZUV1cW1CblVZRHN5dXg3?= =?utf-8?B?ZDY3RTM0K0l4ZGlHcU1OQ1lzMEV1Y0pTWXptNkJiUk1mdEFrOTJ0bDNzME5P?= =?utf-8?B?QmRoUllqU1YzNVVaaXBkV0YraSthTTJhT3lEM0ZwVVd1bTJXZllzaVdXNFhw?= =?utf-8?B?UGQ5TFNmSGRvd2FGbUxxS1hrOTdCR0dZSzNoSnhwRG5PbzNadERsYTNrY3d0?= =?utf-8?B?bkxGSERCRkRqUGtLS1lUTStqcnBqNHArTFRBV1o5ZzlmMVd1c3E0WGhjMkIv?= =?utf-8?B?aFdKa3ZVWmYzaGpyZ1VuRW93cVE2OEluR0xLak52RWsxQkxRT0hhZnRMakhB?= =?utf-8?B?WndHTEVLWXA5S29oN1BicjdsZWRzMjhvVHhIbU5aSUVOc1I5WVN4Tm5pYWhJ?= =?utf-8?B?ZGZzVXptMzV6aTBMazZpNG0vZVlCNWg5Nm8yaFh3cnUyUFAxRDhHSXJOQmhB?= =?utf-8?B?VUZtUkxpZWFhWUVrQ21BcUJzS2svVXhIWDJXRFdLUyt3RHdWL3FocVRUYjJJ?= =?utf-8?B?UVl0U09MQmFEWlNVY2tyaVdyTDNKRW9wRXo0UU5YQWQ0Z09IQUNsZHdaZW1p?= =?utf-8?B?SVZvZUR4U3ZhMVlWNnYzYk1oOWkwVWVKZ21NR21POUhhWHduV1NVT2d4T2Zq?= =?utf-8?B?K0YzUjhDSkczaU5ObG5QNjVrK0tvMkFBOUwzZGpWNFhDNGFkemp3WVZUNGJM?= =?utf-8?B?cHNyYVcybzIvQWt5UjdrcTR4NnBrOVQ5dXV3cDZ4bGh2YkptNlhYY01WaWFB?= =?utf-8?B?SWxTcjVwdjdDWFBxYkorcFpJS1M0d09pWk03ZFVrNjZmdUVSUngyMmUyVEVl?= =?utf-8?B?K2thS1paRGpVaTlRT2FicnRXZDZGYW12bHFkMFJISlBxeDV0d0dLKzdxOGtQ?= =?utf-8?B?MVM1MkNSSjhPVlEvR1Y0bzJWV1QwenRZT084SkVSKytsTDhBL3JadWxMczJj?= =?utf-8?B?MWZKY1JCMStIWTFxSG11VTBHcHVoaVdzKzdJNnQrZ3FmYVBaSmNSWjdQRHdP?= =?utf-8?B?VjFuMVk4VTBvNDZJSTB3MDZXaVpUdGZjWWZydGNwVGRmM3IzcG1XUzNrWlRO?= =?utf-8?Q?HoVBKnSnsrFpwt6uMF4SEEUfLjTyc0eodZLJ8=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;5:x8WrcE0EF8Pzuz4r3vw2zYb39MPL+7KkKIbuelUee3p8DPQg4QJvE1I8QG0Gam10UMbnYcahUPsdR1sZa2Z1H4c90X3hn+ojAu4Q/02HF6SsQQ1peYKlBNBZSf1LH1Yp3NKZNTyXtzGIjNXHCqJHOQ==;24:pJjebnQTnwoyN+GOkHvpVNiJ9bqULVBj/TneGmD5ZPbCflXr3sJCAPnBf+bqp8HZPyYNt2aSol6EhjH+jQSLvzoI56HUvNdYnxkWLHage/U=;20:5Bl9/+8fVtZBX4DB5k5HTbc4clbNZbbrZZALED0W/GxfGrXGxrAdpB7+fj9lZQUN3OL9khFS8gB4KSoCutBYWw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2015 16:42:24.0443 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR12MB0850 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/24/2015 11:33 AM, Borislav Petkov wrote: > > > And that's ugly - I much prefer having input arguments being input only > and return values being return values only. If it can be helped, that > is. And in this case, it is not necessary. Okay, I'll fix this in the next version and do a family check in __set_scrub_rate() itself. > > Yeah, I believe we've talked about this before: a patch should do one > logical change and one logical change *only* - no other unrelated hunks > belong in it. > > Otherwise, they make reviewing it harder by making me wonder why is that > hunk there and what does it have to do with the scrub rate changes. > Unrelated hunks can - further down the road - complicate bisection and > cherry-picking for other kernels. > > So please try to restrain yourself to do solely the one logical change > your patch addresses. > > If you feel that some more work needs to be done on the file or the > whole driver, you can always send *separate* patches ontop which we can > discuss. > Okay, Sorry about that. Will clean it up in V2. Thanks, -Aravind.