From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751740AbbIXSx2 (ORCPT ); Thu, 24 Sep 2015 14:53:28 -0400 Received: from www62.your-server.de ([213.133.104.62]:57692 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbbIXSx1 (ORCPT ); Thu, 24 Sep 2015 14:53:27 -0400 Message-ID: <560446A2.2020907@iogearbox.net> Date: Thu, 24 Sep 2015 20:53:22 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andrzej Hajda , linux-kernel@vger.kernel.org CC: Bartlomiej Zolnierkiewicz , Marek Szyprowski , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> <1443103227-25612-18-git-send-email-a.hajda@samsung.com> In-Reply-To: <1443103227-25612-18-git-send-email-a.hajda@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/24/2015 04:00 PM, Andrzej Hajda wrote: > The function returns always non-negative values. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda > --- > Hi, > > To avoid problems with too many mail recipients I have sent whole > patchset only to LKML. Anyway patches have no dependencies. > > Regards > Andrzej > --- > tools/net/bpf_jit_disasm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/net/bpf_jit_disasm.c b/tools/net/bpf_jit_disasm.c > index 2cd3d4c..b422dbe 100644 > --- a/tools/net/bpf_jit_disasm.c > +++ b/tools/net/bpf_jit_disasm.c > @@ -156,7 +156,7 @@ static void put_log_buff(char *buff) > free(buff); > } > > -static int get_last_jit_image(char *haystack, size_t hlen, > +static unsigned int get_last_jit_image(char *haystack, size_t hlen, > uint8_t *image, size_t ilen) I have no problem if you want to change this, but then please also fix up the 2nd line's indentation to match the '(' as it was before. Thanks ! > { > char *ptr, *pptr, *tmp; >