From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Tejun Heo <tj@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH 3/3] blk-mq: Fix the queue freezing mechanism
Date: Thu, 24 Sep 2015 12:04:50 -0700 [thread overview]
Message-ID: <56044952.7040600@sandisk.com> (raw)
In-Reply-To: <20150924112251.2ec061fd@tom-T450>
On 09/23/2015 08:23 PM, Ming Lei wrote:
> One solution I thought of is the following patch, which depends on
> Akinobu's patch (blk-mq: fix freeze queue race
> http://marc.info/?l=linux-kernel&m=143723697010781&w=2).
Has that patch been tested against a debug kernel ? The following call
trace is triggered by that patch:
WARNING: CPU: 3 PID: 200 at kernel/sched/core.c:7485 __might_sleep+0x77/0x80()
do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff810b4593>] prepare_to_wait_event+0x63/0xf0
Modules linked in: ib_srp(O) scsi_transport_srp(O) netconsole configfs af_packet msr sg coretemp x86_pkg_temp_thermal crct10dif_pclmul crc32c_intel aesni_intel aes_x86_64 glue_helper lrw gf128mul ipmi_devintf ablk_helper cryptd tg3 lpc_ich microcode pcspkr libphy mfd_core ipmi_si ipmi_msghandler ib_ipoib rdma_ucm ib_ucm ib_uverbs ib_umad dm_multipath dm_mod rdma_cm ib_cm acpi_power_meter hwmon iw_cm processor button wmi ext4 crc16 mbcache jbd2 mlx4_ib mlx4_en ib_sa ptp pps_core ib_mad ib_core ib_addr sd_mod sr_mod cdrom hid_generic usbhid hid ahci libahci libata ehci_pci ehci_hcd mlx4_core usbcore usb_common scsi_mod autofs4 [last unloaded: brd]
CPU: 3 PID: 200 Comm: kworker/u16:9 Tainted: G O 4.3.0-rc2-debug+ #1
Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 11/17/2014
Workqueue: events_unbound async_run_entry_fn
Call Trace:
[<ffffffff81288603>] dump_stack+0x4b/0x68
[<ffffffff810725c6>] warn_slowpath_common+0x86/0xc0
[<ffffffff8107264c>] warn_slowpath_fmt+0x4c/0x50
[<ffffffff810b4593>] ? prepare_to_wait_event+0x63/0xf0
[<ffffffff810b4593>] ? prepare_to_wait_event+0x63/0xf0
[<ffffffff81099e47>] __might_sleep+0x77/0x80
[<ffffffff814f20a3>] mutex_lock_nested+0x33/0x3b0
[<ffffffff810ba11d>] ? trace_hardirqs_on+0xd/0x10
[<ffffffff810b45c5>] ? prepare_to_wait_event+0x95/0xf0
[<ffffffff812725fa>] blk_mq_queue_enter+0x17a/0x2d0
[<ffffffff812724b3>] ? blk_mq_queue_enter+0x33/0x2d0
[<ffffffff810b4620>] ? prepare_to_wait_event+0xf0/0xf0
[<ffffffff8127368e>] blk_mq_map_request+0x2e/0x330
[<ffffffff810b82e9>] ? __lock_is_held+0x49/0x70
[<ffffffff81274941>] blk_sq_make_request+0x91/0x430
[ ... ]
prev parent reply other threads:[~2015-09-24 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 22:11 [PATCH 0/3] Block layer patches for kernel v4.4 Bart Van Assche
2015-09-23 22:12 ` [PATCH 1/3] blk-cgroup: Declare local symbols static Bart Van Assche
2015-09-25 15:35 ` Tejun Heo
2015-09-23 22:12 ` [PATCH 2/3] bsg: Add sparse annotations to bsg_request_fn() Bart Van Assche
2015-09-23 22:14 ` [PATCH 3/3] blk-mq: Fix the queue freezing mechanism Bart Van Assche
2015-09-24 3:22 ` Ming Lei
2015-09-24 16:43 ` Bart Van Assche
2015-09-24 16:53 ` Tejun Heo
2015-09-24 17:35 ` Bart Van Assche
2015-09-24 17:49 ` Tejun Heo
2015-09-24 18:09 ` Bart Van Assche
2015-09-24 18:14 ` Tejun Heo
2015-09-24 22:54 ` Bart Van Assche
2015-09-24 22:56 ` Tejun Heo
2015-09-24 19:04 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56044952.7040600@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=akinobu.mita@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).