From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752449AbbIXXkb (ORCPT ); Thu, 24 Sep 2015 19:40:31 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:50190 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723AbbIXXk3 convert rfc822-to-8bit (ORCPT ); Thu, 24 Sep 2015 19:40:29 -0400 X-AuditID: cbfee68d-f79ae6d00000149a-9f-560489ebd4c4 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <560489EA.5040305@samsung.com> Date: Fri, 25 Sep 2015 08:40:26 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andrzej Hajda , linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , MyungJoo Ham Subject: Re: [PATCH 12/19] extcon: rt8973a: fix handling regmap_irq_get_virq result References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> <1443103227-25612-13-git-send-email-a.hajda@samsung.com> In-reply-to: <1443103227-25612-13-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsWyRsSkQPd1J0uYwbG/Vha31p1jtdg4Yz2r xeVdc9gs1h65y25xu3EFmwOrR9+WVYwenzfJBTBFcdmkpOZklqUW6dslcGU8XMNfcIGz4v3S bewNjG/Yuxg5OSQETCTO/doKZYtJXLi3nq2LkYtDSGAFo8SWl/cZYYo6t91hhEgsZZR4e/4R C0iCV0BQ4sfke2A2s4C6xKR5i5ghbBGJb/OnskLY2hLLFr5mhmh+wCix6fc3ZohmLYl5C7+B NbMIqEo8vr8PzGYDiu9/cQPoDA4OUYEIie4TlSBhEQFXiTXHX4BdxywwiVGibdYDVpAaYYFQ iRcr3EFqhATqJBavnMsCEuYEqr+3NAGkXEJgHbvE/rvfWCFWCUh8m3wIrEZCQFZi0wFmiB8l JQ6uuMEygVF8FpLPZiH5bBaSz2Yh+WwBI8sqRtHUguSC4qT0IkO94sTc4tK8dL3k/NxNjMCI O/3vWe8OxtsHrA8xCnAwKvHwKrayhAmxJpYVV+YeYjQFumgis5Rocj4wrvNK4g2NzYwsTE1M jY3MLc2UxHkVpX4GCwmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamC8e7UvwmpmU6vz5jxH8wtT 1z/aMNetOfK+mPIr39OHFkwXtF8VI2i1Kv3PzIedmj89Nh2b9c8txCznUJvi7SlfTx1hUPy8 8K3UvU4bk/1fd3Gue34gcR6zi9Dvb93ZBdw3Dv2PmCivqbFo+exKh0Y1jdfCB9cmynLysaQt 3ecsx9vjbtun4/5diaU4I9FQi7moOBEAfruhELMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t9jAd3XnSxhBs9+mVrcWneO1WLjjPWs Fpd3zWGzWHvkLrvF7cYVbA6sHn1bVjF6fN4kF8AU1cBok5GamJJapJCal5yfkpmXbqvkHRzv HG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0TkmhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Su b0gQXI+RARpIWMOYcXXHd8aCTZwV9478ZGtgPMfexcjJISFgItG57Q4jhC0mceHeerYuRi4O IYGljBJvzz9iAUnwCghK/Jh8D8jm4GAWkJc4cikbJMwsoC4xad4iZoj6B4wSm35/Y4ao15KY t/AbWC+LgKrE4/v7wGw2oPj+FzfYQOaICkRIdJ+oBAmLCLhKrDn+Amwvs8AkRom2WQ9YQWqE BUIlXqxwB6kREqiTWLxyLtgJnED195YmTGAUmIXkuFkIx81CctwCRuZVjBKpBckFxUnpuUZ5 qeV6xYm5xaV56XrJ+bmbGMEx+kx6B+PhXe6HGAU4GJV4eBVaWcKEWBPLiitzDzFKcDArifAy JACFeFMSK6tSi/Lji0pzUosPMZoCfTeRWUo0OR+YPvJK4g2NTcyMLI3MDS2MjM2VxHlvHGII ExJITyxJzU5NLUgtgulj4uCUamBUkrZPb+3tTPtjcGjDYv/J1+8ws8wW9F0pydSe6ntf2Hv7 gqYwrgrpiTovw10yLgpsWzC7jmF6iljn1hCdDymNXy0OeW4+wbLiTTb3ZtXY4/K72LTm7rui aOh3McCgLOJXUXzETc7wf4/Ppz/7MfswX9+CAi0H5cf3XH4zKs2WWfxWKVLLyUWJpTgj0VCL uag4EQCqqVxO5wIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 09월 24일 23:00, Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda > --- > Hi, > > To avoid problems with too many mail recipients I have sent whole > patchset only to LKML. Anyway patches have no dependencies. > > Regards > Andrzej > --- > drivers/extcon/extcon-rt8973a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/extcon-rt8973a.c > index 3428b6a..1bc3737 100644 > --- a/drivers/extcon/extcon-rt8973a.c > +++ b/drivers/extcon/extcon-rt8973a.c > @@ -594,7 +594,7 @@ static int rt8973a_muic_i2c_probe(struct i2c_client *i2c, > > for (i = 0; i < info->num_muic_irqs; i++) { > struct muic_irq *muic_irq = &info->muic_irqs[i]; > - unsigned int virq = 0; > + int virq = 0; > > virq = regmap_irq_get_virq(info->irq_data, muic_irq->irq); > if (virq <= 0) > Applied it. Thanks, Chanwoo Choi