From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752818AbbIXXkh (ORCPT ); Thu, 24 Sep 2015 19:40:37 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:34799 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723AbbIXXke (ORCPT ); Thu, 24 Sep 2015 19:40:34 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79ae6d00000149a-dc-560489f19f80 Content-transfer-encoding: 8BIT Message-id: <560489F1.8070306@samsung.com> Date: Fri, 25 Sep 2015 08:40:33 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andrzej Hajda , linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , MyungJoo Ham Subject: Re: [PATCH 13/19] extcon: sm5502: fix handling regmap_irq_get_virq result References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> <1443103227-25612-14-git-send-email-a.hajda@samsung.com> In-reply-to: <1443103227-25612-14-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgkeLIzCtJLcpLzFFi42JZI2JSqPuxkyXM4NJPYYtb686xWmycsZ7V 4vKuOWwWa4/cZbe43biCzYHVo2/LKkaPz5vkApiiuGxSUnMyy1KL9O0SuDKudl9hLFjDWbF2 0w+2BsYT7F2MnBwSAiYSX09dYoawxSQu3FvP1sXIxSEksIJR4m3nRiaYojfdzcwQiaWMEstf /gPr5hUQlPgx+R5LFyMHB7OAvMSRS9kgYWYBdYlJ8xZB1T9glJh3cTEjRL2WxI+9v1hAbBYB VYnvPevAbDag+P4XN9hA5ogKREh0n6gECYsIuEqsOf4C7CBmgUmMEm2zHrCCJIQFQiRuNfWC 9QoJ1ElsXNTGDNLLCdQw50wtSL2EwDp2idlb+5kgdglIfJt8COxOCQFZiU0HoB6WlDi44gbL BEaxWUi+mYXwzSwk3yxgZF7FKJpakFxQnJReZKhXnJhbXJqXrpecn7uJERhBp/89693BePuA 9SFGAQ5GJR5exVaWMCHWxLLiytxDjKZAR0xklhJNzgfGaV5JvKGxmZGFqYmpsZG5pZmSOK+i 1M9gIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYwmPkErJ85589r7puTx8MAsBkutaZtMV0gH ynx+f+2+86N9UmmuM9vrjjd8+ptwMOHk8Yi4uoDrl5/pX9jCKH3myJkFSuH2Xab73nDO/jvx CF9e9Rm1zb3rnDZnuITuUuk8sZrd2GHZzML4hS+uKX542v1M3pTlkL7lzHCLI9IxcnteHpzM IzVPiaU4I9FQi7moOBEAmadNRZsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t9jAd2PnSxhBvt38VvcWneO1WLjjPWs Fpd3zWGzWHvkLrvF7cYVbA6sHn1bVjF6fN4kF8AU1cBok5GamJJapJCal5yfkpmXbqvkHRzv HG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0TkmhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Su b0gQXI+RARpIWMOYcbX7CmPBGs6KtZt+sDUwnmDvYuTkkBAwkXjT3cwMYYtJXLi3nq2LkYtD SGApo8Tyl//AingFBCV+TL7H0sXIwcEsIC9x5FI2SJhZQF1i0rxFzBD1Dxgl5l1czAhRryXx Y+8vFhCbRUBV4nvPOjCbDSi+/8UNNpA5ogIREt0nKkHCIgKuEmuOvwDbyywwiVGibdYDVpCE sECIxK2mXrBeIYE6iY2L2phBejmBGuacqZ3AKDALyXWzEK6bheS6BYzMqxglUguSC4qT0nON 8lLL9YoTc4tL89L1kvNzNzGCo/SZ9A7Gw7vcDzEKcDAq8fAqtLKECbEmlhVX5h5ilOBgVhLh ZUgACvGmJFZWpRblxxeV5qQWH2I0BXpvIrOUaHI+MIHklcQbGpuYGVkamRtaGBmbK4nz3jjE ECYkkJ5YkpqdmlqQWgTTx8TBKdXAeLT8q3Xs8wd/l1i3ht839Flr+eH+/xjnSwGZQmVXMi+q skZP+LntZVROi69j57mzHScWzlzlLvxgicK/00oSnBEXHS/w9m5f3uaUPu+ytLjmQ40idVHu XUpMftprDkYcmf6jsXHSBnWDwwksPbGfLx2T3FH9yPxLjMJNqXd5d/m0goWP+39PVWIpzkg0 1GIuKk4EACmFmg/oAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 09월 24일 23:00, Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda > --- > Hi, > > To avoid problems with too many mail recipients I have sent whole > patchset only to LKML. Anyway patches have no dependencies. > > Regards > Andrzej > --- > drivers/extcon/extcon-sm5502.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c > index 92ae484..2945091 100644 > --- a/drivers/extcon/extcon-sm5502.c > +++ b/drivers/extcon/extcon-sm5502.c > @@ -586,7 +586,7 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c, > > for (i = 0; i < info->num_muic_irqs; i++) { > struct muic_irq *muic_irq = &info->muic_irqs[i]; > - unsigned int virq = 0; > + int virq = 0; > > virq = regmap_irq_get_virq(info->irq_data, muic_irq->irq); > if (virq <= 0) > Applied it. Thanks, Chanwoo Choi