From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753728AbbIYAyu (ORCPT ); Thu, 24 Sep 2015 20:54:50 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:49190 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752569AbbIYAys (ORCPT ); Thu, 24 Sep 2015 20:54:48 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f791c6d000001498-e8-56049b420c58 Content-transfer-encoding: 8BIT Message-id: <56049B42.7030509@samsung.com> Date: Fri, 25 Sep 2015 09:54:26 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Charles Keepax , lee.jones@linaro.org Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, myungjoo.ham@samsung.com, sameo@linux.intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5 References: <1442397404-7579-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1442397404-7579-5-git-send-email-ckeepax@opensource.wolfsonmicro.com> In-reply-to: <1442397404-7579-5-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMIsWRmVeSWpSXmKPExsWyRsSkWNdpNkuYwfwtJhb/ptxgt5h/5Byr Rf+bhawW516tZLS4//Uoo8XlXXPYLJZev8hkcbtxBZvFhOlrWSxa9x5htzjdzerA7bFm3hpG j8t9vUweK5d/YfPYtKqTzePOtT1sHvNOBnq8nPibzaNvyypGj8+b5AI4o7hsUlJzMstSi/Tt Ergy9j4ULZguVHGvMaGB8Q1fFyMnh4SAicTlr3uZIWwxiQv31rN1MXJxCAmsYJSYOHkLO0zR vLMPmSASSxkl1rX2s4IkeAUEJX5MvsfSxcjBwSwgL3HkUjZImFlAXWLSvEVgQ4UEHjBKbH5f CFGuJXGocTITiM0ioCpxaV0HG4jNBhTf/+IGG8gYUYEIie4TlSBhEQE/iQ8777JAjHzCKLFx FViJsECSxM/L5RDXzGWU2LPiCCNIDadAqETDqs+MECd3ckjsfsgGsUpA4tvkQ2BXSgjISmw6 APWupMTBFTdYJjCKzULyyyyEX2Yh+WUBI/MqRtHUguSC4qT0IiO94sTc4tK8dL3k/NxNjMC4 Pf3vWd8OxpsHrA8xCnAwKvHwKrayhAmxJpYVV+YeYjQFOmIis5Rocj4wOeSVxBsamxlZmJqY GhuZW5opifMmSP0MFhJITyxJzU5NLUgtii8qzUktPsTIxMEp1cDosfO3ZLHYc4cduR0FUz45 T5ITOLHyRe3BOdVeLwJV/H7OrPyW7urXFOy3+ief0xa1jX++ZZ6JXc5pekaqN/XS5kjJ9YY/ 3+w5kTRrkd37O2tiFRjtNdL+K3nOXH5Q9tZCjjwVMTuVsw922Yb9fBT6rTz0Q0DC6T3L840/ nKrV/rE502lHxIFkJZbijERDLeai4kQAQPXPEtYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsVy+t9jAV2n2SxhBlOu6Vn8m3KD3WL+kXOs Fv1vFrJanHu1ktHi/tejjBaXd81hs1h6/SKTxe3GFWwWE6avZbFo3XuE3eJ0N6sDt8eaeWsY PS739TJ5rFz+hc1j06pONo871/awecw7GejxcuJvNo++LasYPT5vkgvgjGpgtMlITUxJLVJI zUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBulZJoSwxpxQoFJBYXKyk b4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmLH3oWjBdKGKe40JDYxv+LoYOTkkBEwk5p19yARh i0lcuLeerYuRi0NIYCmjxLrWflaQBK+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtMmreIGcQW EnjAKLH5fSFEuZbEocbJYDNZBFQlLq3rYAOx2YDi+1/cYAMZIyoQIdF9ohIkLCLgJ/Fh510W iJFPGCU2rgIrERZIkvh5uRzimrmMEntWHGEEqeEUCJVoWPWZcQKjwCwkx81COG4WkuMWMDKv YpRILUguKE5KzzXKSy3XK07MLS7NS9dLzs/dxAhODs+kdzAe3uV+iFGAg1GJh1ehlSVMiDWx rLgy9xCjBAezkggvQwJQiDclsbIqtSg/vqg0J7X4EKMp0HsTmaVEk/OBiSuvJN7Q2MTMyNLI 3NDCyNhcSZz3xiGGMCGB9MSS1OzU1ILUIpg+Jg5OqQbGZtb2ZmPG7c32Qr8tft92U+tMm7jT j3H12z/77p3tunep7VS5qkXCy79zzotrfJTgr9WTYv3HnWkw23TytkPctlvq2CT+/z77g0fk fePWn91fS96nmrOG8eyZErSPn5979/w30lk+2XH6V923tbUanP42/4O+w+npCTPPd8R2bXid O0WU+WmhEktxRqKhFnNRcSIA8obvVCQDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Charles, I have one comment. I think current extcon-arizona.c has the many platform data so, extcon-arizona.c use the too much if statement to support each feature for different wolfsonmicro codec. I think it cause the complicated code. For example, You may use 'struct of_device_id' as following. You used already this method on drivers/mfd/arizona-core.c. If you separate the function of each wmXXXX arizona, it makes improved readability for extcon-arizona.c and some user will use extcon-arizora more easily. struct arizona_extcon_data { void (*init)(...); void (*irq_handler)(...); ... }; struct arizona_extcon_data wm8994_data { .init = wm8994_extcon_init, .irq_handler = wm8994_extcon_irq_handler; ... }; static const struct of_device_id arizona_extcon_dt_match[] = { { .compatible = "wm8994-arizona-extcon", .data = (void *)wm8994_data; }, { .compatible = "wmXXXX-arizona-extcon", .data = (void *)wmXXXX_data; }, }; I expect that you will revise the arizona-extcon.c driver on next time. Thanks, Chanwoo Choi On 2015년 09월 16일 18:56, Charles Keepax wrote: > Some Arizona devices have the option to use the GPIO5 pin as a second > jack detection pin. This patch adds device bindings to specify to the > driver that it should use this pin. Note that the second jack detection > pin is hard wired in the chip so can only be enabled through the > binding, rather than a pin being specified. > > Signed-off-by: Charles Keepax > Acked-by: Chanwoo Choi > --- > drivers/extcon/extcon-arizona.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index dc1910d..992f80e 100644 > --- a/drivers/extcon/extcon-arizona.c > +++ b/drivers/extcon/extcon-arizona.c > @@ -1235,6 +1235,11 @@ static int arizona_extcon_device_get_pdata(struct arizona *arizona) > > device_property_read_u32(arizona->dev, "wlf,gpsw", &pdata->gpsw); > > + pdata->jd_gpio5 = device_property_read_bool(arizona->dev, > + "wlf,use-jd-gpio"); > + pdata->jd_gpio5_nopull = device_property_read_bool(arizona->dev, > + "wlf,use-jd-gpio-nopull"); > + > return 0; > } > >