From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755369AbbIYHxl (ORCPT ); Fri, 25 Sep 2015 03:53:41 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36204 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752979AbbIYHxk (ORCPT ); Fri, 25 Sep 2015 03:53:40 -0400 Subject: Re: [PATCH] KVM: nVMX: emulate the INVVPID instruction To: Bandan Das References: <56026541.7030000@redhat.com> Cc: Wanpeng Li , Jan Kiszka , Wincy Van , kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <5604FD7E.3060901@redhat.com> Date: Fri, 25 Sep 2015 09:53:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/09/2015 17:45, Bandan Das wrote: > > However, I have applied the patch to kvm/queue. Please send the changes > > separately, and I will squash them in the existing VPID patch. > > Please don't do this. It's making it really difficult to review these > patches individually :( Why not let them get some review time before > applying them all together ? Ok---I did it because it makes sense to keep this patch separate from the others. You can expose VPID even if vpid02 == vpid01 (in fact that's what happens if KVM cannot find a vpid02) and in that case this patch provides a valid implementation of INVVPID. Do you think it would help if I posted the whole kvm/queue contents a few days before pushing it to kvm/next? Paolo