From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932386AbbIYPqb (ORCPT ); Fri, 25 Sep 2015 11:46:31 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:33468 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756666AbbIYPq3 (ORCPT ); Fri, 25 Sep 2015 11:46:29 -0400 Subject: Re: Problems with printk logs and my driver To: Jiri Kosina , Felipe Tonello References: Cc: Alan Stern , Eric Curtin , USB list , Kernel development list From: Austin S Hemmelgarn Message-ID: <56056C22.7050807@gmail.com> Date: Fri, 25 Sep 2015 11:45:38 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-512; boundary="------------ms080905060003080608070108" X-Antivirus: avast! (VPS 150925-0, 2015-09-25), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms080905060003080608070108 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 2015-09-25 08:02, Jiri Kosina wrote: > On Fri, 25 Sep 2015, Felipe Tonello wrote: > >> Maybe a better description on Kconfig and/or comments on source code >> it's enough. > > I personally find the current Kconfig description: > > =3D=3D=3D > config USB_KBD > tristate "USB HIDBP Keyboard (simple Boot) support" > depends on USB && INPUT > ---help--- > Say Y here only if you are absolutely sure that you don't wa= nt > to use the generic HID driver for your USB keyboard and pref= er > to use the keyboard in its limited Boot Protocol mode instea= d. > > This is almost certainly not what you want. This is mostly > useful for embedded applications or simple keyboards. > > To compile this driver as a module, choose M here: the > module will be called usbkbd. > > If even remotely unsure, say N. > =3D=3D=3D > > shouldn't leave anyone dounting, but people are getting confused again = and > again nevertheless. > For some reason there seem to be a lot of people who go to configure=20 there own kernel and don't read the help text (I understand if you've=20 been building your own Linux kernel's for years and actually understand=20 what a Kconfig option is really asking, but most people who I've heard=20 of doing this have never built a kernel before in their life). On the other hand, can anyone think of any real reason to use this=20 outside of embedded systems? I know there are a lot of distros that=20 build this and the USB HIDBP mouse support as modules, but I have yet to = hear/find any reports of hardware that _only_ works with this driver and = not the generic HID driver. If this is the case, it might make sense to = make this depend on EXPERT or at least remove the bit about 'simple=20 keyboards'. --------------ms080905060003080608070108 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgMFADCABgkqhkiG9w0BBwEAAKCC Brgwgga0MIIEnKADAgECAgMRLfgwDQYJKoZIhvcNAQENBQAweTEQMA4GA1UEChMHUm9vdCBD QTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNp Z25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcwHhcN MTUwOTIxMTEzNTEzWhcNMTYwMzE5MTEzNTEzWjBjMRgwFgYDVQQDEw9DQWNlcnQgV29UIFVz ZXIxIzAhBgkqhkiG9w0BCQEWFGFoZmVycm9pbjdAZ21haWwuY29tMSIwIAYJKoZIhvcNAQkB FhNhaGVtbWVsZ0BvaGlvZ3QuY29tMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA nQ/81tq0QBQi5w316VsVNfjg6kVVIMx760TuwA1MUaNQgQ3NyUl+UyFtjhpkNwwChjgAqfGd LIMTHAdObcwGfzO5uI2o1a8MHVQna8FRsU3QGouysIOGQlX8jFYXMKPEdnlt0GoQcd+BtESr pivbGWUEkPs1CwM6WOrs+09bAJP3qzKIr0VxervFrzrC5Dg9Rf18r9WXHElBuWHg4GYHNJ2V Ab8iKc10h44FnqxZK8RDN8ts/xX93i9bIBmHnFfyNRfiOUtNVeynJbf6kVtdHP+CRBkXCNRZ qyQT7gbTGD24P92PS2UTmDfplSBcWcTn65o3xWfesbf02jF6PL3BCrVnDRI4RgYxG3zFBJuG qvMoEODLhHKSXPAyQhwZINigZNdw5G1NqjXqUw+lIqdQvoPijK9J3eijiakh9u2bjWOMaleI SMRR6XsdM2O5qun1dqOrCgRkM0XSNtBQ2JjY7CycIx+qifJWsRaYWZz0aQU4ZrtAI7gVhO9h pyNaAGjvm7PdjEBiXq57e4QcgpwzvNlv8pG1c/hnt0msfDWNJtl3b6elhQ2Pz4w/QnWifZ8E BrFEmjeeJa2dqjE3giPVWrsH+lOvQQONsYJOuVb8b0zao4vrWeGmW2q2e3pdv0Axzm/60cJQ haZUv8+JdX9ZzqxOm5w5eUQSclt84u+D+hsCAwEAAaOCAVkwggFVMAwGA1UdEwEB/wQCMAAw VgYJYIZIAYb4QgENBEkWR1RvIGdldCB5b3VyIG93biBjZXJ0aWZpY2F0ZSBmb3IgRlJFRSBo ZWFkIG92ZXIgdG8gaHR0cDovL3d3dy5DQWNlcnQub3JnMA4GA1UdDwEB/wQEAwIDqDBABgNV HSUEOTA3BggrBgEFBQcDBAYIKwYBBQUHAwIGCisGAQQBgjcKAwQGCisGAQQBgjcKAwMGCWCG SAGG+EIEATAyBggrBgEFBQcBAQQmMCQwIgYIKwYBBQUHMAGGFmh0dHA6Ly9vY3NwLmNhY2Vy dC5vcmcwMQYDVR0fBCowKDAmoCSgIoYgaHR0cDovL2NybC5jYWNlcnQub3JnL3Jldm9rZS5j cmwwNAYDVR0RBC0wK4EUYWhmZXJyb2luN0BnbWFpbC5jb22BE2FoZW1tZWxnQG9oaW9ndC5j b20wDQYJKoZIhvcNAQENBQADggIBADMnxtSLiIunh/TQcjnRdf63yf2D8jMtYUm4yDoCF++J jCXbPQBGrpCEHztlNSGIkF3PH7ohKZvlqF4XePWxpY9dkr/pNyCF1PRkwxUURqvuHXbu8Lwn 8D3U2HeOEU3KmrfEo65DcbanJCMTTW7+mU9lZICPP7ZA9/zB+L0Gm1UNFZ6AU50N/86vjQfY WgkCd6dZD4rQ5y8L+d/lRbJW7ZGEQw1bSFVTRpkxxDTOwXH4/GpQfnfqTAtQuJ1CsKT12e+H NSD/RUWGTr289dA3P4nunBlz7qfvKamxPymHeBEUcuICKkL9/OZrnuYnGROFwcdvfjGE5iLB kjp/ttrY4aaVW5EsLASNgiRmA6mbgEAMlw3RwVx0sVelbiIAJg9Twzk4Ct6U9uBKiJ8S0sS2 8RCSyTmCRhJs0vvva5W9QUFGmp5kyFQEoSfBRJlbZfGX2ehI2Hi3U2/PMUm2ONuQG1E+a0AP u7I0NJc/Xil7rqR0gdbfkbWp0a+8dAvaM6J00aIcNo+HkcQkUgtfrw+C2Oyl3q8IjivGXZqT 5UdGUb2KujLjqjG91Dun3/RJ/qgQlotH7WkVBs7YJVTCxfkdN36rToPcnMYOI30FWa0Q06gn F6gUv9/mo6riv3A5bem/BdbgaJoPnWQD9D8wSyci9G4LKC+HQAMdLmGoeZfpJzKHMYIE0TCC BM0CAQEwgYAweTEQMA4GA1UEChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNl cnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcN AQkBFhJzdXBwb3J0QGNhY2VydC5vcmcCAxEt+DANBglghkgBZQMEAgMFAKCCAiEwGAYJKoZI hvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTUwOTI1MTU0NTM4WjBPBgkq hkiG9w0BCQQxQgRAkTYcJ26H2iqg3mImt0/swZwSirlqGks/SyCLZEHYeGcy9AhIrPK+hqEX M1CPduNYDF9C3PL6mEjHaYrDlcPmOzBsBgkqhkiG9w0BCQ8xXzBdMAsGCWCGSAFlAwQBKjAL BglghkgBZQMEAQIwCgYIKoZIhvcNAwcwDgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3DQMCAgFA MAcGBSsOAwIHMA0GCCqGSIb3DQMCAgEoMIGRBgkrBgEEAYI3EAQxgYMwgYAweTEQMA4GA1UE ChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlD QSBDZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2Vy dC5vcmcCAxEt+DCBkwYLKoZIhvcNAQkQAgsxgYOggYAweTEQMA4GA1UEChMHUm9vdCBDQTEe MBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNpZ25p bmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcCAxEt+DAN BgkqhkiG9w0BAQEFAASCAgB72fK9DkhR9Yz3W0t7sTpHfvmLSSr7fP2HpVdXSG5rE565xwCW K7rlkNGPXCxZ5RyjTD91ENDRI8ZtbzerzgurJYUyl2roy2P+dRcZhYNBY7MOoIVEJS1jTkr+ hNXhhfy7LO9MK00sdZq4QqpnCLaIAnKmKQb87dB722IiHQP6jU0X0wa3kvYVDBwSV9uP6QzT 70y5U4yO5szMuWsYo9hFW4EUuTywvD2yaoRPQXDaX3kFu6Lx6a6llz1VuS4K7cUx6ukdziFT +uOSGVEGb55waDRup+DptoHwTwiMIZPL3LGo4IS9IBziuPl9h0NjKRNVfDQq/R+4LEgGfJGB pacCqJrHe8o+2ba4m7ZNDQKjN0BN+4DiTwjCJKDTjjmDoTwU7OHzJzQUrLCFz5O6l3O8shtJ GT6rQXEZdAlR3e7xS8p6kOx8fRMslCryRcaz+whU8xeDsSo3bIBwDkf/WGqxK4OQ1ZMgTNMK ZHQRh9GWE6m+Dp/+jfSgncU99SILM/q360AkcgqYbeyh2rUypxEi8KUWfY6vaT4OTufRrob1 xV3zQ3oo4j/p0x7evmBYAnMoDH6oZrOtjDv50NhU2hZIx1syNTxYzQNbso9n+WE2sWwSgzIW 8lphlViHhvt0Js9ZRynkBUbWTP3I4gwvdCBaq9Vg/dr56zXD0p3JHS8syAAAAAAAAA== --------------ms080905060003080608070108--