From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932931AbbIYSD5 (ORCPT ); Fri, 25 Sep 2015 14:03:57 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:36780 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932812AbbIYSDz (ORCPT ); Fri, 25 Sep 2015 14:03:55 -0400 Subject: Re: [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected To: Sudip Mukherjee , "David S. Miller" , Hans-Christian Egtvedt References: <1443089813-10967-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Andrew Morton From: Sergei Shtylyov Message-ID: <56058C88.3070907@cogentembedded.com> Date: Fri, 25 Sep 2015 21:03:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443089813-10967-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 9/24/2015 1:16 PM, Sudip Mukherjee wrote: > The builds of allmodconfig of avr32 is failing with: > > drivers/net/ethernet/via/via-rhine.c:1098:2: error: implicit declaration > of function 'pci_iomap' [-Werror=implicit-function-declaration] > drivers/net/ethernet/via/via-rhine.c:1119:2: error: implicit declaration > of function 'pci_iounmap' [-Werror=implicit-function-declaration] > > The generic empty pci_iomap and pci_iounmap is used only if CONFIG_PCI > is not defined and CONFIG_GENERIC_PCI_IOMAP is defined. > > Add GENERIC_PCI_IOMAP in the dependency list for VIA_RHINE as we are > getting build failure when CONFIG_PCI and CONFIG_GENERIC_PCI_IOMAP both > are not defined. > > Signed-off-by: Sudip Mukherjee > --- > > Failed build log is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/81127188 > > An exactly similar patch has been posted earlier and relevant discussion > is at: > https://patchwork.ozlabs.org/patch/498722/ > > I posted a patch to include empty pci_iomap, pci_iounmap in avr32. That > discussion is at: > https://lkml.org/lkml/2015/9/19/100 > > drivers/net/ethernet/via/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/via/Kconfig b/drivers/net/ethernet/via/Kconfig > index 2f1264b..17831e5 100644 > --- a/drivers/net/ethernet/via/Kconfig > +++ b/drivers/net/ethernet/via/Kconfig > @@ -17,7 +17,7 @@ if NET_VENDOR_VIA > > config VIA_RHINE > tristate "VIA Rhine support" > - depends on (PCI || OF_IRQ) > + depends on (PCI || (OF_IRQ && GENERIC_PCI_IOMAP)) Could you remove outer braces, while at it? [...] MBR, Sergei