From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933083AbbIYTNr (ORCPT <rfc822;w@1wt.eu>);
	Fri, 25 Sep 2015 15:13:47 -0400
Received: from bear.ext.ti.com ([192.94.94.41]:59275 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932890AbbIYTNp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 25 Sep 2015 15:13:45 -0400
Subject: Re: [PATCH v3 3/5] mfd: tps65912: Add driver for the TPS65912 PMIC
To: Lee Jones <lee.jones@linaro.org>
References: <1443106374-4126-1-git-send-email-afd@ti.com>
 <1443106374-4126-4-git-send-email-afd@ti.com> <20150925165059.GI27197@x1>
CC: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Samuel Ortiz <sameo@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>, <linux-gpio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: "Andrew F. Davis" <afd@ti.com>
Message-ID: <56059CDA.4020004@ti.com>
Date: Fri, 25 Sep 2015 14:13:30 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150925165059.GI27197@x1>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/25/2015 11:50 AM, Lee Jones wrote:
> On Thu, 24 Sep 2015, Andrew F. Davis wrote:
>
>> This patch adds support for TPS65912 mfd device. It provides
>> communication through the I2C and SPI interfaces. It contains
>> the following components:
>>
>>   - Regulators
>>   - GPIO controller
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>>   drivers/mfd/Kconfig          |  24 +++
>>   drivers/mfd/Makefile         |   3 +
>>   drivers/mfd/tps65912-core.c  | 114 +++++++++++++
>>   drivers/mfd/tps65912-i2c.c   |  86 ++++++++++
>>   drivers/mfd/tps65912-spi.c   |  85 ++++++++++
>>   include/linux/mfd/tps65912.h | 393 +++++++++++++++++++++++++++++++++++++++++++
>>   6 files changed, 705 insertions(+)
>>   create mode 100644 drivers/mfd/tps65912-core.c
>>   create mode 100644 drivers/mfd/tps65912-i2c.c
>>   create mode 100644 drivers/mfd/tps65912-spi.c
>>   create mode 100644 include/linux/mfd/tps65912.h
>
> [...]
>
>> +#define TPS65912_IRQ(_name, _reg, _offset)			\
>> +	[TPS65912_IRQ_ ## _name] = {				\
>> +		.mask = TPS65912_ ## _reg ## _ ## _name,	\
>> +		.reg_offset = _offset,				\
>> +	}
>
> I told you about this already.
>
> If you want this set to be merged for v4.3 then you'll need commit
> b4fe8ba ("regmap: Add generic macro to define regmap_irq") from my
> tree.
>

You asked me to submit this to Mark Brown, I didn't realize you also
wanted me to use the one in your tree. Using yours will make my lines
over 80 chars and so it kind of defeats the purpose but I'll do it
for v4.

> [...]
>
>> +static struct i2c_driver tps65912_i2c_driver = {
>> +	.driver		= {
>> +		.name	= "tps65912",
>> +		.of_match_table = tps65912_i2c_of_match_table,
>
> of_match_ptr()
>

Why? tps65912_i2c_of_match_table is always compiled in.

> [...]
>