From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755624AbbIZByA (ORCPT ); Fri, 25 Sep 2015 21:54:00 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53204 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753475AbbIZBx6 (ORCPT ); Fri, 25 Sep 2015 21:53:58 -0400 Subject: Re: [PATCH] platform: x86: PMC IPC depends on ACPI To: Lee Jones , linux-kernel@vger.kernel.org References: <1443199123-13979-1-git-send-email-lee.jones@linaro.org> Cc: qipeng.zha@intel.com, dvhart@infradead.org, platform-driver-x86@vger.kernel.org From: Randy Dunlap Message-ID: <5605FAB4.9000606@infradead.org> Date: Fri, 25 Sep 2015 18:53:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443199123-13979-1-git-send-email-lee.jones@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/25/15 09:38, Lee Jones wrote: > This patch solves: > > on x86_64: > > when CONFIG_ACPI is not enabled: > > ../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe': > ../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2: > error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration] > status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv); > ^ > > Reported-by: Randy Dunlap > Signed-off-by: Lee Jones Works for me. Thanks. Acked-by: Randy Dunlap > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index c69bb70..744cb80 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -914,6 +914,7 @@ config PVPANIC > > config INTEL_PMC_IPC > tristate "Intel PMC IPC Driver" > + depends on ACPI > ---help--- > This driver provides support for PMC control on some Intel platforms. > The PMC is an ARC processor which defines IPC commands for communication > -- ~Randy