From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932544AbbIZDnG (ORCPT <rfc822;w@1wt.eu>);
	Fri, 25 Sep 2015 23:43:06 -0400
Received: from mail1.windriver.com ([147.11.146.13]:39439 "EHLO
	mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932295AbbIZDnF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 25 Sep 2015 23:43:05 -0400
Subject: Re: [PATCH] powercap / RAPL : remove dependency on iosf_mbi
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
References: <1442475101-1872-1-git-send-email-pengyu.ma@windriver.com>
 <1542119.JQ7HNYzFZu@vostro.rjw.lan> <20150918084356.4bf149a6@yairi>
 <55FF7DFE.8050906@windriver.com> <20150921143629.4f597e1c@icelake>
 <5600C6E8.50602@windriver.com> <20150922100149.36ae0251@icelake>
 <5603CA74.8010201@windriver.com> <20150924093341.744c26d4@icelake>
CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>, <rafael.j.wysocki@intel.com>,
        <linux-kernel@vger.kernel.org>, "Box, David E" <david.e.box@intel.com>,
        "Anvin, H Peter" <h.peter.anvin@intel.com>
From: Pengyu Ma <pengyu.ma@windriver.com>
Message-ID: <56061440.1060007@windriver.com>
Date: Sat, 26 Sep 2015 11:42:56 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150924093341.744c26d4@icelake>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

$ objdump --dwarf drivers/powercap/intel_rapl.o |grep iosf
     <65ad>   DW_AT_name        : (indirect string, offset: 0x3644): 
iosf_mbi_read
     <65f7>   DW_AT_name        : (indirect string, offset: 0x496): 
iosf_mbi_write
   5    3    0    0    iosf_mbi.h
   0x00000490 656c5f69 6400696f 73665f6d 62695f77 el_id.iosf_mbi_w
   0x00003640 72656700 696f7366 5f6d6269 5f726561 reg.iosf_mbi_rea

$ grep -i iosf_mbi .config
# CONFIG_IOSF_MBI is not set

It is compiled and included by header file.

Pengyu

On 09/25/2015 12:33 AM, Jacob Pan wrote:
> On Thu, 24 Sep 2015 18:03:32 +0800
> Pengyu Ma <pengyu.ma@windriver.com> wrote:
>
>>> So the problematic case is when RAPL=Y IOSF=M
>>> Since real IOSF functions are available when
>>> #if IS_ENABLED(CONFIG_IOSF_MBI)
>>> There will be no dummy functions for RAPL to reference in this
>>> case.
>> iosf_mbi_write/read will warn itself.
> it does not compile.